Changeset 29946

Timestamp:

10/17/2014 08:59:23 PM (9 years ago)

Author:

jorbin

Message:

Check if WP_DEFAULT_THEME starts with twenty before asserting it is in default theme array

This fixes an issue that if you change WP_DEFAULT_THEME and run core unit tests, the tests fail since your theme isn't one of the hard coded lists of default themes. We need to keep this test to make sure that we update the array of default themes for use in other tests.

If we ever change the naming convention for default themes, this will need to be updated.

props nacin for initial idea
fixes #29925

File:

• trunk/tests/phpunit/tests/theme.php (modified) (1 diff)

trunk/tests/phpunit/tests/theme.php

@@ -166 +166 @@
     }
 
+    /**
+     * Make sure we update the default theme list to include the lastest default theme
+     * @ticket 29925
+     */
+    function test_default_theme_in_default_theme_list(){
+        if ( substr(WP_DEFAULT_THEME, 0, 6) === 'twenty') {
+            $this->assertContains( WP_DEFAULT_THEME, $this->default_themes );
+        }
+    }
+
     function test_default_themes_have_textdomain() {
-        $this->assertContains( WP_DEFAULT_THEME, $this->default_themes );
         foreach ( $this->default_themes as $theme ) {
             $this->assertEquals( $theme, wp_get_theme( $theme )->get( 'TextDomain' ) );