Changeset 29980

Timestamp:

10/21/2014 01:40:33 PM (9 years ago)

Author:

boonebgorges

Message:

Improve unit tests for 'status' param in WP_Comment_Query.

See #29612.

File:

• trunk/tests/phpunit/tests/comment/query.php (modified) (2 diffs)

trunk/tests/phpunit/tests/comment/query.php

@@ -19 +19 @@
      * @ticket 21101
      */
-    function test_get_comment_comment_approved_0() {
-        $comment_id = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id ) );
-        $comments_approved_0 = get_comments( array( 'status' => 'hold' ) );
-        $this->assertEquals( 0, count( $comments_approved_0 ) );
+    public function test_status_hold() {
+        $c1 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_approved' => '1' ) );
+        $c2 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_approved' => '0' ) );
+
+        $q = new WP_Comment_Query();
+        $found = $q->query( array(
+            'status' => 'hold',
+            'fields' => 'ids',
+        ) );
+
+        $this->assertEquals( array( $c2 ), $found );
     }
 
@@ -28 +35 @@
      * @ticket 21101
      */
-    function test_get_comment_comment_approved_1() {
-        $comment_id = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id ) );
-        $comments_approved_1 = get_comments( array( 'status' => 'approve' ) );
-
-        $this->assertEquals( 1, count( $comments_approved_1 ) );
-        $result = $comments_approved_1[0];
-
-        $this->assertEquals( $comment_id, $result->comment_ID );
+    public function test_status_approve() {
+        $c1 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_approved' => '1' ) );
+        $c2 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_approved' => '0' ) );
+
+        $q = new WP_Comment_Query();
+        $found = $q->query( array(
+            'status' => 'approve',
+            'fields' => 'ids',
+        ) );
+
+        $this->assertEquals( array( $c1 ), $found );
+    }
+
+    public function test_status_custom() {
+        $c1 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_approved' => '1' ) );
+        $c2 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_approved' => 'foo' ) );
+        $c3 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_approved' => 'foo1' ) );
+
+        $q = new WP_Comment_Query();
+        $found = $q->query( array(
+            'status' => 'foo',
+            'fields' => 'ids',
+        ) );
+
+        $this->assertEquals( array( $c2 ), $found );
+    }
+
+    public function test_status_all() {
+        $c1 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_approved' => '1' ) );
+        $c2 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_approved' => 'foo' ) );
+        $c3 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_approved' => '0' ) );
+
+        $q = new WP_Comment_Query();
+        $found = $q->query( array(
+            'status' => 'all',
+            'fields' => 'ids',
+        ) );
+
+        $this->assertEqualSets( array( $c1, $c3 ), $found );
     }