Changeset 30003 for trunk/src/wp-includes/comment.php

Timestamp:

10/24/2014 02:33:46 AM (11 years ago)

Author:

boonebgorges

Message:

Add unit tests for WP_Comment_Query 'orderby' param.

For better testability, the SQL string generated in WP_Comment_Query::get_posts()
is now stored as a 'request' property on the object.

See #29902.

File:

• trunk/src/wp-includes/comment.php (modified) (2 diffs)

trunk/src/wp-includes/comment.php

@@ -222 +222 @@
  */
 class WP_Comment_Query {
+    /**
+     * SQL for database query.
+     *
+     * @since 4.0.1
+     * @access public
+     * @var string
+     */
+    public $request;
+
     /**
      * Metadata query container
@@ -579 +588 @@
             $groupby = 'GROUP BY ' . $groupby;
         }
-        $query = "SELECT $fields FROM $wpdb->comments $join WHERE $where $groupby ORDER BY $orderby $order $limits";
+
+        $this->request = "SELECT $fields FROM $wpdb->comments $join WHERE $where $groupby $orderby $order $limits";
 
         if ( $this->query_vars['count'] ) {
-            return $wpdb->get_var( $query );
+            return $wpdb->get_var( $this->request );
         }
 
         if ( 'ids' == $this->query_vars['fields'] ) {
-            $this->comments = $wpdb->get_col( $query );
+            $this->comments = $wpdb->get_col( $this->request );
             return array_map( 'intval', $this->comments );
         }
 
-        $results = $wpdb->get_results( $query );
+        $results = $wpdb->get_results( $this->request );
         /**
          * Filter the comment query results.