Changeset 30016 for trunk/src/wp-includes/user.php

Timestamp:

10/24/2014 07:50:53 PM (10 years ago)

Author:

boonebgorges

Message:

Accept 'orderby=include' in WP_User_Query.

This lets the results of a user query be sorted manually by the value of the
'include' param.

Props jipmoors.
Fixes #30064.

File:

• trunk/src/wp-includes/user.php (modified) (3 diffs)

trunk/src/wp-includes/user.php

@@ -599 +599 @@
         $this->query_where = "WHERE 1=1";
 
+        // Parse and sanitize 'include', for use by 'orderby' as well as 'include' below.
+        if ( ! empty( $qv['include'] ) ) {
+            $include = wp_parse_id_list( $qv['include'] );
+        } else {
+            $include = false;
+        }
+
         // sorting
         if ( isset( $qv['orderby'] ) ) {
@@ -622 +629 @@
             } elseif ( 'meta_value' == $qv['orderby'] ) {
                 $orderby = "$wpdb->usermeta.meta_value";
+            } else if ( 'include' === $qv['orderby'] && ! empty( $include ) ) {
+                // Sanitized earlier.
+                $include_sql = implode( ',', $include );
+                $orderby = "FIELD( $wpdb->users.ID, $include_sql )";
             } else {
                 $orderby = 'user_login';
@@ -735 +746 @@
         }
 
-        if ( ! empty( $qv['include'] ) ) {
-            $ids = implode( ',', wp_parse_id_list( $qv['include'] ) );
+        if ( ! empty( $include ) ) {
+            // Sanitized earlier.
+            $ids = implode( ',', $include );
             $this->query_where .= " AND $wpdb->users.ID IN ($ids)";
         } elseif ( ! empty( $qv['exclude'] ) ) {