Changeset 30052

Timestamp:

10/28/2014 06:12:30 PM (10 years ago)

Author:

boonebgorges

Message:

Introduce orderby=include support for get_terms().

Props wpsmith.
Fixes #23261.

Location:

trunk

Files:

• src/wp-includes/taxonomy.php (modified) (1 diff)
• tests/phpunit/tests/term/getTerms.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -1713 +1713 @@
     } else if ( 'slug' == $_orderby ) {
         $orderby = 't.slug';
+    } else if ( 'include' == $_orderby && ! empty( $args['include'] ) ) {
+        $include = implode( ',', array_map( 'absint', $args['include'] ) );
+        $orderby = "FIELD( t.term_id, $include )";
     } else if ( 'term_group' == $_orderby ) {
         $orderby = 't.term_group';

trunk/tests/phpunit/tests/term/getTerms.php

@@ -797 +797 @@
     }
 
+    /**
+     * @ticket 23261
+     */
+    public function test_orderby_include() {
+        $tax = 'wptests_tax';
+        register_taxonomy( $tax, 'post' );
+
+        $t1 = $this->factory->term->create( array( 'taxonomy' => $tax ) );
+        $t2 = $this->factory->term->create( array( 'taxonomy' => $tax ) );
+        $t3 = $this->factory->term->create( array( 'taxonomy' => $tax ) );
+        $t4 = $this->factory->term->create( array( 'taxonomy' => $tax ) );
+
+        $found = get_terms( $tax, array(
+            'fields' => 'ids',
+            'include' => array( $t4, $t1, $t2 ),
+            'orderby' => 'include',
+            'hide_empty' => false,
+        ) );
+
+        _unregister_taxonomy( 'wptests_tax' );
+
+        $this->assertEquals( array( $t4, $t1, $t2 ), $found );
+    }
+
     protected function create_hierarchical_terms_and_posts() {