Changeset 30082 for trunk/src/wp-includes/media.php

Timestamp:

10/29/2014 12:46:15 AM (12 years ago)

Author:

wonderboymusic

Message:

Don't hardcode height for videos - this was a workaround for MediaElement internals causing problems. Responsive videos now work properly and don't cause extra whitespace.

Fixes MediaElement by hand in the interim: ​https://github.com/johndyer/mediaelement/pull/1337
Video playlists were completely broken by this.

Fixes #30078.

File:

• trunk/src/wp-includes/media.php (modified) (1 diff)

trunk/src/wp-includes/media.php

@@ -1856 +1856 @@
     $html .= '</video>';
 
-    $width_rule = $height_rule = '';
+    $width_rule = '';
     if ( ! empty( $atts['width'] ) ) {
         $width_rule = sprintf( 'width: %dpx; ', $atts['width'] );
     }
-    if ( ! empty( $atts['height'] ) ) {
-        $height_rule = sprintf( 'height: %dpx; ', $atts['height'] );
-    }
-    $output = sprintf( '<div style="%s%s" class="wp-video">%s</div>', $width_rule, $height_rule, $html );
+    $output = sprintf( '<div style="%s" class="wp-video">%s</div>', $width_rule, $html );
 
     /**