Changeset 30093

Timestamp:

10/29/2014 07:50:31 PM (10 years ago)

Author:

boonebgorges

Message:

Support an empty string passed as a status in WP_Comment_Query.

The changes in [30084] broke backward compatibility with interfaces that
manually passed an empty string for the value of 'status', such as on
wp-admin/edit-comments.php.

Fixes #29612.

Location:

trunk

Files:

• src/wp-includes/comment.php (modified) (2 diffs)
• tests/phpunit/tests/comment/query.php (modified) (1 diff)

trunk/src/wp-includes/comment.php

@@ -356 +356 @@
         }
 
-        // Remove empty statuses.
-        $statuses = array_filter( $statuses );
-
         // 'any' overrides other statuses.
         if ( ! in_array( 'any', $statuses ) ) {
@@ -372 +369 @@
 
                     case 'all' :
+                    case '' :
                         $status_clauses[] = "( comment_approved = '0' OR comment_approved = '1' )";
                         break;

trunk/tests/phpunit/tests/comment/query.php

@@ -14 +14 @@
 
         $this->post_id = $this->factory->post->create();
+    }
+
+    /**
+     * @ticket 29612
+     */
+    public function test_status_empty_string() {
+        $c1 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_approved' => '1' ) );
+        $c2 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_approved' => '0' ) );
+        $c3 = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_approved' => 'spam' ) );
+
+        $q = new WP_Comment_Query();
+        $found = $q->query( array(
+            'status' => '',
+            'fields' => 'ids',
+        ) );
+
+        $this->assertEqualSets( array( $c1, $c2 ), $found );
     }