Changeset 30148

Timestamp:

11/01/2014 04:00:59 AM (10 years ago)

Author:

boonebgorges

Message:

Clean up 'post-thumbnail' theme support unit tests.

• Separate into smaller test methods.
• Remove incorrect tests. A number of assertions in the existing test have always incorrectly described the behavior of current_theme_supports( 'post-thumbnails' ), but no one ever noticed because the tests had been designed to bail when _wp_render_title_tag() did not exist. The failures finally became visible when that function was introduced in [30074].

See #18548.

File:

• trunk/tests/phpunit/tests/theme/support.php (modified) (4 diffs)

trunk/tests/phpunit/tests/theme/support.php

@@ -35 +35 @@
     }
 
-    function test_post_thumbnails() {
+    public function test_post_thumbnails() {
         add_theme_support( 'post-thumbnails' );
         $this->assertTrue( current_theme_supports( 'post-thumbnails' ) );
@@ -42 +42 @@
         add_theme_support( 'post-thumbnails' );
         $this->assertTrue( current_theme_supports( 'post-thumbnails' ) );
+    }
 
-        // simple array of post types.
+    public function test_post_thumbnails_flat_array_of_post_types() {
         add_theme_support( 'post-thumbnails', array( 'post', 'page' ) );
         $this->assertTrue( current_theme_supports( 'post-thumbnails' ) );
@@ -50 +51 @@
         remove_theme_support( 'post-thumbnails' );
         $this->assertFalse( current_theme_supports( 'post-thumbnails' ) );
+    }
 
-        #WP18548
-        if ( ! function_exists( '_wp_render_title_tag' ) )
-            return;
-
-        // array of arguments, with the key of 'types' holding the post types.
-        add_theme_support( 'post-thumbnails', array( 'types' => array( 'post', 'page' ) ) );
-        $this->assertTrue( current_theme_supports( 'post-thumbnails' ) );
-        $this->assertTrue( current_theme_supports( 'post-thumbnails', 'post' ) );
-        $this->assertFalse( current_theme_supports( 'post-thumbnails', 'book' ) );
-        remove_theme_support( 'post-thumbnails' );
-        $this->assertFalse( current_theme_supports( 'post-thumbnails' ) );
-
+    public function test_post_thumbnails_types_true() {
         // array of arguments, with the key of 'types' holding the post types.
         add_theme_support( 'post-thumbnails', array( 'types' => true ) );
@@ -69 +60 @@
         remove_theme_support( 'post-thumbnails' );
         $this->assertFalse( current_theme_supports( 'post-thumbnails' ) );
-
-        // array of arguments, with some other argument, and no 'types' argument.
-        add_theme_support( 'post-thumbnails', array( rand_str() => rand_str() ) );
-        $this->assertTrue( current_theme_supports( 'post-thumbnails' ) );
-        $this->assertTrue( current_theme_supports( 'post-thumbnails', rand_str() ) ); // any type
-        remove_theme_support( 'post-thumbnails' );
-        $this->assertFalse( current_theme_supports( 'post-thumbnails' ) );
-
     }