Changeset 30153

Timestamp:

11/01/2014 07:44:07 PM (10 years ago)

Author:

wonderboymusic

Message:

In wp_xmlrpc_server methods, for comprehensibility:

• initialize arrays in loops, instead of overriding an uninitialized array each time
• in ->blogger_getRecentPosts() and ->mw_getRecentPosts(), remove the extra loops by only setting one array

See #30224.

File:

• trunk/src/wp-includes/class-wp-xmlrpc-server.php (modified) (12 diffs)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -2764 +2764 @@
         if ( $all_tags = get_tags() ) {
             foreach( (array) $all_tags as $tag ) {
+                $struct = array();
                 $struct['tag_id']           = $tag->term_id;
                 $struct['name']             = $tag->name;
@@ -3221 +3222 @@
             return new IXR_Error( 404, __( 'Invalid post ID.' ) );
 
+        $comment = array();
         $comment['comment_post_ID'] = $post_id;
 
@@ -3484 +3486 @@
             return new IXR_Error( 403, __( 'You are not allowed to update options.' ) );
 
+        $option_names = array();
         foreach ( $options as $o_name => $o_value ) {
             $option_names[] = $o_name;
@@ -3629 +3632 @@
                     $supported = get_theme_support( 'post-formats' );
 
+                    $data = array();
                     $data['all'] = $formats;
                     $data['supported'] = $supported[0];
@@ -4075 +4079 @@
         }
 
+        $recent_posts = array();
         foreach ($posts_list as $entry) {
             if ( !current_user_can( 'edit_post', $entry['ID'] ) )
@@ -4086 +4091 @@
             $content .= wp_unslash($entry['post_content']);
 
-            $struct[] = array(
+            $recent_posts[] = array(
                 'userid' => $entry['post_author'],
                 'dateCreated' => $post_date,
@@ -4092 +4097 @@
                 'postid' => (string) $entry['ID'],
             );
-
-        }
-
-        $recent_posts = array();
-        for ( $j=0; $j<count($struct); $j++ ) {
-            array_push($recent_posts, $struct[$j]);
         }
 
@@ -5103 +5102 @@
             return array();
 
-        $struct = array();
+        $recent_posts = array();
         foreach ($posts_list as $entry) {
             if ( !current_user_can( 'edit_post', $entry['ID'] ) )
@@ -5147 +5146 @@
                 $post_format = 'standard';
 
-            $struct[] = array(
+            $recent_posts[] = array(
                 'dateCreated' => $post_date,
                 'userid' => $entry['post_author'],
@@ -5175 +5174 @@
                 'date_modified_gmt' => $post_modified_gmt,
                 'sticky' => ( $entry['post_type'] === 'post' && is_sticky( $entry['ID'] ) ),
+                'wp_post_thumbnail' => get_post_thumbnail_id( $entry['ID'] )
             );
-
-            $entry_index = count( $struct ) - 1;
-            $struct[ $entry_index ][ 'wp_post_thumbnail' ] = get_post_thumbnail_id( $entry['ID'] );
-        }
-
-        $recent_posts = array();
-        for ( $j=0; $j<count($struct); $j++ ) {
-            array_push($recent_posts, $struct[$j]);
         }
 
@@ -5217 +5209 @@
         if ( $cats = get_categories(array('get' => 'all')) ) {
             foreach ( $cats as $cat ) {
+                $struct = array();
                 $struct['categoryId'] = $cat->term_id;
                 $struct['parentId'] = $cat->parent;
@@ -5437 +5430 @@
         if ( $cats = get_categories(array('hide_empty' => 0, 'hierarchical' => 0)) ) {
             foreach ( $cats as $cat ) {
+                $struct = array();
                 $struct['categoryId'] = $cat->term_id;
                 $struct['categoryName'] = $cat->name;