Changeset 30185

Timestamp:

11/03/2014 05:02:18 AM (10 years ago)

Author:

wonderboymusic

Message:

In wp_audio|video_shortcode(), make sure that autoplay and loop are booleans. Passing 'false' to them will force them to be active, which is bad.

Fixes #29825.

File:

• trunk/src/wp-includes/media.php (modified) (2 diffs)

trunk/src/wp-includes/media.php

@@ -1576 +1576 @@
         'class'    => apply_filters( 'wp_audio_shortcode_class', 'wp-audio-shortcode' ),
         'id'       => sprintf( 'audio-%d-%d', $post_id, $instances ),
-        'loop'     => $atts['loop'],
-        'autoplay' => $atts['autoplay'],
+        'loop'     => wp_validate_boolean( $atts['loop'] ),
+        'autoplay' => wp_validate_boolean( $atts['autoplay'] ),
         'preload'  => $atts['preload'],
         'style'    => 'width: 100%; visibility: hidden;',
@@ -1802 +1802 @@
         'height'   => absint( $atts['height'] ),
         'poster'   => esc_url( $atts['poster'] ),
-        'loop'     => $atts['loop'],
-        'autoplay' => $atts['autoplay'],
+        'loop'     => wp_validate_boolean( $atts['loop'] ),
+        'autoplay' => wp_validate_boolean( $atts['autoplay'] ),
         'preload'  => $atts['preload'],
     );