Changeset 30250

Timestamp:

11/06/2014 07:02:33 AM (12 years ago)

Author:

nacin

Message:

Quicktags: move focusing the editor after inserting content to the end of the code blocks.

Merges [29884] to the 4.0 branch.

Fixes a bug in Chrome where both the textarea and the window may auto-scroll to unexpected position on clicking a Quicktags button.

props azaozz, avryl.
fixes #29944.

Location:

branches/4.0

Files:

• . (modified) (1 prop)
• src/wp-includes/js/quicktags.js (modified) (2 diffs)

branches/4.0/src/wp-includes/js/quicktags.js

@@ -385 +385 @@
                         canvas.value = text.substring(0, startPos) + content + text.substring(endPos, text.length);
 
-                        canvas.focus();
                         canvas.selectionStart = startPos + content.length;
                         canvas.selectionEnd = startPos + content.length;
                         canvas.scrollTop = scrollTop;
+                        canvas.focus();
                 } else {
                         canvas.value += content;
@@ -510 +510 @@
                         }
 
-                        canvas.focus();
                         canvas.selectionStart = cursorPos;
                         canvas.selectionEnd = cursorPos;
                         canvas.scrollTop = scrollTop;
+                        canvas.focus();
                 } else { // other browsers?
                         if ( !endTag ) {