Changeset 30261

Timestamp:

11/06/2014 08:22:32 AM (11 years ago)

Author:

nacin

Message:

In wp_audio|video_shortcode(), make sure that autoplay and loop are booleans. Passing 'false' to them will force them to be active, which is bad.

Merges [30185] to the 4.0 branch.

props wonderboymusic.
fixes #29825.

Location:

branches/4.0

Files:

• . (modified) (1 prop)
• src/wp-includes/media.php (modified) (2 diffs)

branches/4.0/src/wp-includes/media.php

@@ -1597 +1597 @@
         'class'    => apply_filters( 'wp_audio_shortcode_class', 'wp-audio-shortcode' ),
         'id'       => sprintf( 'audio-%d-%d', $post_id, $instances ),
-        'loop'     => $atts['loop'],
-        'autoplay' => $atts['autoplay'],
+        'loop'     => wp_validate_boolean( $atts['loop'] ),
+        'autoplay' => wp_validate_boolean( $atts['autoplay'] ),
         'preload'  => $atts['preload'],
         'style'    => 'width: 100%; visibility: hidden;',
@@ -1823 +1823 @@
         'height'   => absint( $atts['height'] ),
         'poster'   => esc_url( $atts['poster'] ),
-        'loop'     => $atts['loop'],
-        'autoplay' => $atts['autoplay'],
+        'loop'     => wp_validate_boolean( $atts['loop'] ),
+        'autoplay' => wp_validate_boolean( $atts['autoplay'] ),
         'preload'  => $atts['preload'],
     );