Changeset 30305

Timestamp:

11/11/2014 07:35:40 PM (10 years ago)

Author:

iandstewart

Message:

Twenty Fifteen: Minor formatting and docs tweaks, clearer variable name.

Props celloexpressions, see #29988

Location:

trunk/src/wp-content/themes/twentyfifteen

Files:

• inc/customizer.php (modified) (6 diffs)
• js/color-scheme-control.js (modified) (3 diffs)
• js/customize-preview.js (modified) (3 diffs)

trunk/src/wp-content/themes/twentyfifteen/inc/customizer.php

@@ -18 +18 @@
     $color_scheme = twentyfifteen_get_color_scheme();
 
-    $wp_customize->get_setting( 'blogname' )->transport         = 'postMessage';
-    $wp_customize->get_setting( 'blogdescription' )->transport  = 'postMessage';
+    $wp_customize->get_setting( 'blogname' )->transport        = 'postMessage';
+    $wp_customize->get_setting( 'blogdescription' )->transport = 'postMessage';
 
     // Add color scheme setting and control.
@@ -255 +255 @@
 
 /**
- * Binds JS handlers to make Customizer preview reload changes asynchronously.
+ * Binds JS handlers to make the Customizer preview reload changes asynchronously.
  *
  * @since Twenty Fifteen 1.0
@@ -266 +266 @@
 /**
  * Output an Underscore template for generating CSS for the color scheme.
+ *
+ * The template generates the css dynamically for instant display in the Customizer preview,
+ * and to be saved in a `theme_mod` for display on the front-end.
  *
  * @since Twenty Fifteen 1.0
@@ -513 +516 @@
     .site-title a:hover,
     .site-title a:focus {
-        color: {{ data.sidebar_textcolor2 }};
+        color: {{ data.secondary_sidebar_textcolor }};
     }
 
@@ -593 +596 @@
         .widget .wp-caption-text,
         .widget .gallery-caption {
-            color: {{ data.sidebar_textcolor2 }};
+            color: {{ data.secondary_sidebar_textcolor }};
         }
 
@@ -606 +609 @@
         .widget_calendar tbody a:hover,
         .widget_calendar tbody a:focus {
-            background-color: {{ data.sidebar_textcolor2 }};
+            background-color: {{ data.secondary_sidebar_textcolor }};
         }
 
         .widget blockquote {
-            border-color: {{ data.sidebar_textcolor2 }};
+            border-color: {{ data.secondary_sidebar_textcolor }};
         }
 

trunk/src/wp-content/themes/twentyfifteen/js/color-scheme-control.js

@@ -2 +2 @@
 /**
  * Add a listener to the Color Scheme control to update other color controls to new values/defaults.
+ * Also trigger an update of the Color Scheme CSS when a color is changed.
  */
 
@@ -46 +47 @@
     } );
 
+    // Generate the CSS for the current Color Scheme.
     function getCSS() {
         var scheme = api( 'color_scheme' )(),
@@ -59 +61 @@
         colors['border_color'] = Color( colors.textcolor ).toCSS( 'rgba', 0.1 );
         colors['border_focus_color'] = Color( colors.textcolor ).toCSS( 'rgba', 0.3 );
-        colors['sidebar_textcolor2'] = Color( colors.sidebar_textcolor ).toCSS( 'rgba', 0.7 );
+        colors['secondary_sidebar_textcolor'] = Color( colors.sidebar_textcolor ).toCSS( 'rgba', 0.7 );
         colors['sidebar_border_color'] = Color( colors.sidebar_textcolor ).toCSS( 'rgba', 0.1 );
         colors['sidebar_border_focus_color'] = Color( colors.sidebar_textcolor ).toCSS( 'rgba', 0.3 );

trunk/src/wp-content/themes/twentyfifteen/js/customize-preview.js

@@ -11 +11 @@
     }
 
-    // Site title and description.
+    // Site title.
     wp.customize( 'blogname', function( value ) {
         value.bind( function( to ) {
@@ -18 +18 @@
     } );
 
+    // Site tagline.
     wp.customize( 'blogdescription', function( value ) {
         value.bind( function( to ) {
@@ -23 +24 @@
         } );
     } );
-    
+
+    // Color Scheme CSS.
     wp.customize( 'color_scheme_css', function( value ) {
         value.bind( function( to ) {