Changeset 30327

Timestamp:

11/13/2014 11:59:23 AM (10 years ago)

Author:

ocean90

Message:

Improve keyboard accessibility on Custom Header and Custom Background screen.

props florianziegler.
fixes #29289.

Location:

trunk/src

Files:

• wp-admin/custom-background.php (modified) (1 diff)
• wp-admin/custom-header.php (modified) (2 diffs)
• wp-content/themes/twentyfifteen/inc/custom-header.php (modified) (1 diff)
• wp-content/themes/twentythirteen/inc/custom-header.php (modified) (1 diff)
• wp-content/themes/twentytwelve/inc/custom-header.php (modified) (1 diff)

trunk/src/wp-admin/custom-background.php

@@ -318 +318 @@
     <p>
         <label for="choose-from-library-link"><?php _e( 'Or choose an image from your media library:' ); ?></label><br />
-        <a id="choose-from-library-link" class="button"
+        <button id="choose-from-library-link" class="button"
             data-choose="<?php esc_attr_e( 'Choose a Background Image' ); ?>"
-            data-update="<?php esc_attr_e( 'Set as background' ); ?>"><?php _e( 'Choose Image' ); ?></a>
+            data-update="<?php esc_attr_e( 'Set as background' ); ?>"><?php _e( 'Choose Image' ); ?></button>
     </p>
     </form>

trunk/src/wp-admin/custom-header.php

@@ -558 +558 @@
             $style = ' style="display:none;"';
         ?>
-        <h1><a id="name" class="displaying-header-text" <?php echo $style; ?> onclick="return false;" href="<?php bloginfo('url'); ?>"><?php bloginfo( 'name' ); ?></a></h1>
+        <h1><a id="name" class="displaying-header-text" <?php echo $style; ?> onclick="return false;" href="<?php bloginfo('url'); ?>" tabindex="-1"><?php bloginfo( 'name' ); ?></a></h1>
         <div id="desc" class="displaying-header-text" <?php echo $style; ?>><?php bloginfo( 'description' ); ?></div>
     </div>
@@ -605 +605 @@
     <p>
         <label for="choose-from-library-link"><?php _e( 'Or choose an image from your media library:' ); ?></label><br />
-        <a id="choose-from-library-link" class="button"
+        <button id="choose-from-library-link" class="button"
             data-update-link="<?php echo esc_attr( $modal_update_href ); ?>"
             data-choose="<?php esc_attr_e( 'Choose a Custom Header' ); ?>"
-            data-update="<?php esc_attr_e( 'Set as header' ); ?>"><?php _e( 'Choose Image' ); ?></a>
+            data-update="<?php esc_attr_e( 'Set as header' ); ?>"><?php _e( 'Choose Image' ); ?></button>
     </p>
     </form>

trunk/src/wp-content/themes/twentyfifteen/inc/custom-header.php

@@ -144 +144 @@
 ?>
     <div id="headimg" style="background-image: url(<?php header_image(); ?>); background-color: <?php echo esc_attr( $header_background_color ); ?>;">
-        <h1 class="displaying-header-text"><a id="name"<?php echo $style; ?> onclick="return false;" href="<?php echo esc_url( home_url( '/' ) ); ?>"><?php bloginfo( 'name' ); ?></a></h1>
+        <h1 class="displaying-header-text"><a id="name"<?php echo $style; ?> onclick="return false;" href="<?php echo esc_url( home_url( '/' ) ); ?>" tabindex="-1"><?php bloginfo( 'name' ); ?></a></h1>
         <div id="desc" class="displaying-header-text"<?php echo $style; ?>><?php bloginfo( 'description' ); ?></div>
     </div>

trunk/src/wp-content/themes/twentythirteen/inc/custom-header.php

@@ -221 +221 @@
         <?php $style = ' style="color:#' . get_header_textcolor() . ';"'; ?>
         <div class="home-link">
-            <h1 class="displaying-header-text"><a id="name"<?php echo $style; ?> onclick="return false;" href="#"><?php bloginfo( 'name' ); ?></a></h1>
+            <h1 class="displaying-header-text"><a id="name"<?php echo $style; ?> onclick="return false;" href="#" tabindex="-1"><?php bloginfo( 'name' ); ?></a></h1>
             <h2 id="desc" class="displaying-header-text"<?php echo $style; ?>><?php bloginfo( 'description' ); ?></h2>
         </div>

trunk/src/wp-content/themes/twentytwelve/inc/custom-header.php

@@ -156 +156 @@
             $style = ' style="color:#' . get_header_textcolor() . ';"';
         ?>
-        <h1 class="displaying-header-text"><a id="name"<?php echo $style; ?> onclick="return false;" href="<?php echo esc_url( home_url( '/' ) ); ?>"><?php bloginfo( 'name' ); ?></a></h1>
+        <h1 class="displaying-header-text"><a id="name"<?php echo $style; ?> onclick="return false;" href="<?php echo esc_url( home_url( '/' ) ); ?>"  tabindex="-1"><?php bloginfo( 'name' ); ?></a></h1>
         <h2 id="desc" class="displaying-header-text"<?php echo $style; ?>><?php bloginfo( 'description' ); ?></h2>
         <?php $header_image = get_header_image();