Changeset 30334

Timestamp:

11/13/2014 03:53:52 PM (10 years ago)

Author:

ocean90

Message:

Improvements to [30333]:

• Move .hide-if-no-js class to table row
• Add a wrapper class
• Add missing translators comment

see #30264.

Location:

trunk/src/wp-admin

Files:

• js/user-profile.js (modified) (2 diffs)
• user-edit.php (modified) (2 diffs)

trunk/src/wp-admin/js/user-profile.js

@@ -125 +125 @@
     });
 
-    $('#destroy-sessions').on('click',function(e){
+    $( '#destroy-sessions' ).on( 'click', function( e ) {
 
         var $this = $(this);
@@ -147 +147 @@
 
         e.preventDefault();
-
     });
 

trunk/src/wp-admin/user-edit.php

@@ -489 +489 @@
 
 <?php if ( IS_PROFILE_PAGE && ( count( $sessions->get_all() ) > 1 ) ) { ?>
-    <tr>
+    <tr class="user-sessions-wrap hide-if-no-js">
         <th>&nbsp;</th>
         <td>
-            <p><button class="button button-secondary hide-if-no-js" id="destroy-sessions" data-token="<?php echo esc_attr( wp_get_session_token() ); ?>"><?php _e( 'Log Out of All Other Sessions' ); ?></button></p>
-            <p class="description hide-if-no-js">
+            <p><button class="button button-secondary" id="destroy-sessions" data-token="<?php echo esc_attr( wp_get_session_token() ); ?>"><?php _e( 'Log Out of All Other Sessions' ); ?></button></p>
+            <p class="description">
                 <?php _e( 'Left your account logged in at a public computer? Lost your phone? This will log you out everywhere except your current browser.' ); ?>
             </p>
@@ -499 +499 @@
     </tr>
 <?php } else if ( ! IS_PROFILE_PAGE && ( count( $sessions->get_all() ) > 0 ) ) { ?>
-    <tr>
+    <tr class="user-sessions-wrap hide-if-no-js">
         <th>&nbsp;</th>
         <td>
-            <p><button class="button button-secondary hide-if-no-js" id="destroy-sessions"><?php _e( 'Log Out of All Sessions' ); ?></button></p>
-            <p class="description hide-if-no-js">
-                <?php printf( __( 'Log %s out of all sessions' ), $profileuser->display_name ); ?>
+            <p><button class="button button-secondary" id="destroy-sessions"><?php _e( 'Log Out of All Sessions' ); ?></button></p>
+            <p class="description">
+                <?php
+                /* translators: 1: User's display name. */
+                printf( __( 'Log %s out of all sessions' ), $profileuser->display_name );
+                ?>
             </p>
         </td>