Changeset 30337

Timestamp:

11/13/2014 10:03:15 PM (10 years ago)

Author:

jorbin

Message:

When asserting microtime output as a number, make it a number

microtime is by default a string. Doing a greater then or less than check of that string is a bad idea since it uses the first part (the micro part of microtime) rather then the actual time. This adds a helper to convert microtime output into a float which we can then use to properly compare the output of microtime.

This fixes an intermittent test failure.

fixes #30336

Location:

trunk/tests/phpunit

Files:

• includes/testcase.php (modified) (2 diffs)
• tests/post/getPages.php (modified) (1 diff)

trunk/tests/phpunit/includes/testcase.php

@@ -145 +145 @@
         }
     }
-    
+
     function flush_cache() {
         global $wp_object_cache;
@@ -477 +477 @@
         return $files;
     }
+
+    /**
+     * Helper to Convert a microtime string into a float
+     */
+    protected function _microtime_to_float($microtime ){
+        $time_array = explode( ' ', $microtime );
+        return array_sum( $time_array );
+    }
 }

trunk/tests/phpunit/tests/post/getPages.php

@@ -80 +80 @@
         // This should bump last_changed.
         wp_delete_post( $pages[0]->ID );
-        $this->assertGreaterThan( $last_changed, wp_cache_get( 'last_changed', 'posts' ) );
+        $old_changed_float = $this->_microtime_to_float( $last_changed );
+        $new_changed_float = $this->_microtime_to_float( wp_cache_get( 'last_changed', 'posts' ) );
+        $this->assertGreaterThan( $old_changed_float, $new_changed_float );
 
         $num_queries = $wpdb->num_queries;