Changeset 30356 for trunk/src/wp-admin/themes.php

Timestamp:

11/16/2014 06:15:29 AM (9 years ago)

Author:

johnbillion

Message:

Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.

Fixes #10551
Props nacin

File:

• trunk/src/wp-admin/themes.php (modified) (3 diffs)

trunk/src/wp-admin/themes.php

@@ -11 +11 @@
 
 if ( !current_user_can('switch_themes') && !current_user_can('edit_theme_options') )
-    wp_die( __( 'Cheatin’ uh?' ) );
+    wp_die( __( 'Cheatin’ uh?' ), 403 );
 
 if ( current_user_can( 'switch_themes' ) && isset($_GET['action'] ) ) {
@@ -18 +18 @@
         $theme = wp_get_theme( $_GET['stylesheet'] );
         if ( ! $theme->exists() || ! $theme->is_allowed() )
-            wp_die( __( 'Cheatin’ uh?' ) );
+            wp_die( __( 'Cheatin’ uh?' ), 403 );
         switch_theme( $theme->get_stylesheet() );
         wp_redirect( admin_url('themes.php?activated=true') );
@@ -26 +26 @@
         $theme = wp_get_theme( $_GET['stylesheet'] );
         if ( !current_user_can('delete_themes') || ! $theme->exists() )
-            wp_die( __( 'Cheatin’ uh?' ) );
+            wp_die( __( 'Cheatin’ uh?' ), 403 );
         delete_theme($_GET['stylesheet']);
         wp_redirect( admin_url('themes.php?deleted=true') );