Changeset 30494 for trunk/tests/phpunit/tests/term/splitSharedTerm.php

Timestamp:

11/21/2014 03:16:08 AM (12 years ago)

Author:

boonebgorges

Message:

Improve cleanup of cached term_ids after shared terms are split.

• If the split term ID is stored as 'default_category', 'default_link_category', or 'default_email_category', update it to the new ID.
• If the split term ID is associated with a nav menu item, update that piece of postmeta to the new ID.

Props mboynes.
See #30335.

File:

• trunk/tests/phpunit/tests/term/splitSharedTerm.php (modified) (8 diffs)

trunk/tests/phpunit/tests/term/splitSharedTerm.php

@@ -5 +5 @@
  */
 class Tests_Term_SplitSharedTerm extends WP_UnitTestCase {
-        protected $tt_ids = array();
+        protected $terms = array();
 
         public function setUp() {
@@ -41 +41 @@
                 ) );
 
-                $this->tt_ids = array(
-                        't1' => $t1['term_taxonomy_id'],
-                        't2' => $t2['term_taxonomy_id'],
-                        't3' => $t3['term_taxonomy_id'],
-                        't2_child' => $t2_child['term_taxonomy_id'],
+                $this->terms = array(
+                        't1' => $t1,
+                        't2' => $t2,
+                        't3' => $t3,
+                        't2_child' => $t2_child,
                 );
 
@@ -56 +56 @@
          */
         public function test_should_create_new_term_ids() {
-                $t1_term = get_term_by( 'term_taxonomy_id', $this->tt_ids['t1'], 'wptests_tax' );
-                $t2_term = get_term_by( 'term_taxonomy_id', $this->tt_ids['t2'], 'wptests_tax_2' );
-                $t3_term = get_term_by( 'term_taxonomy_id', $this->tt_ids['t3'], 'wptests_tax_3' );
+                $t1_term = get_term_by( 'term_taxonomy_id', $this->terms['t1']['term_taxonomy_id'], 'wptests_tax' );
+                $t2_term = get_term_by( 'term_taxonomy_id', $this->terms['t2']['term_taxonomy_id'], 'wptests_tax_2' );
+                $t3_term = get_term_by( 'term_taxonomy_id', $this->terms['t3']['term_taxonomy_id'], 'wptests_tax_3' );
 
                 $this->assertNotEquals( $t1_term->term_id, $t2_term->term_id );
@@ -69 +69 @@
          */
         public function test_should_retain_child_terms_when_using_get_terms_parent() {
-                $t2_term = get_term_by( 'term_taxonomy_id', $this->tt_ids['t2'], 'wptests_tax_2' );
+                $t2_term = get_term_by( 'term_taxonomy_id', $this->terms['t2']['term_taxonomy_id'], 'wptests_tax_2' );
                 $children = get_terms( 'wptests_tax_2', array(
                         'parent' => $t2_term->term_id,
@@ -75 +75 @@
                 ) );
 
-                $this->assertEquals( $this->tt_ids['t2_child'], $children[0]->term_taxonomy_id );
+                $this->assertEquals( $this->terms['t2_child']['term_taxonomy_id'], $children[0]->term_taxonomy_id );
         }
 
@@ -82 +82 @@
          */
         public function test_should_retain_child_terms_when_using_get_terms_child_of() {
-                $t2_term = get_term_by( 'term_taxonomy_id', $this->tt_ids['t2'], 'wptests_tax_2' );
+                $t2_term = get_term_by( 'term_taxonomy_id', $this->terms['t2']['term_taxonomy_id'], 'wptests_tax_2' );
                 $children = get_terms( 'wptests_tax_2', array(
                         'child_of' => $t2_term->term_id,
@@ -88 +88 @@
                 ) );
 
-                $this->assertEquals( $this->tt_ids['t2_child'], $children[0]->term_taxonomy_id );
+                $this->assertEquals( $this->terms['t2_child']['term_taxonomy_id'], $children[0]->term_taxonomy_id );
         }
 
@@ -122 +122 @@
                 $this->assertEquals( array( $new_term_id ), $t2_children );
         }
+
+        /**
+         * @ticket 30335
+         */
+        public function test_should_update_default_category_on_term_split() {
+                global $wpdb;
+                $t1 = wp_insert_term( 'Foo Default', 'category' );
+
+                update_option( 'default_category', $t1['term_id'] );
+
+                register_taxonomy( 'wptests_tax_5', 'post' );
+                $t2 = wp_insert_term( 'Foo Default', 'wptests_tax_5' );
+
+                // Manually modify because split terms shouldn't naturally occur.
+                $wpdb->update( $wpdb->term_taxonomy,
+                        array( 'term_id' => $t1['term_id'] ),
+                        array( 'term_taxonomy_id' => $t2['term_taxonomy_id'] ),
+                        array( '%d' ),
+                        array( '%d' )
+                );
+
+                $this->assertEquals( $t1['term_id'], get_option( 'default_category', -1 ) );
+
+                $new_term_id = _split_shared_term( $t1['term_id'], $t1['term_taxonomy_id'] );
+
+                $this->assertNotEquals( $new_term_id, $t1['term_id'] );
+                $this->assertEquals( $new_term_id, get_option( 'default_category', -1 ) );
+        }
+
+        /**
+         * @ticket 30335
+         */
+        public function test_should_update_menus_on_term_split() {
+                global $wpdb;
+
+                $t1 = wp_insert_term( 'Foo Menu', 'category' );
+
+                register_taxonomy( 'wptests_tax_6', 'post' );
+                $t2 = wp_insert_term( 'Foo Menu', 'wptests_tax_6' );
+
+                // Manually modify because split terms shouldn't naturally occur.
+                $wpdb->update( $wpdb->term_taxonomy,
+                        array( 'term_id' => $t1['term_id'] ),
+                        array( 'term_taxonomy_id' => $t2['term_taxonomy_id'] ),
+                        array( '%d' ),
+                        array( '%d' )
+                );
+
+                $menu_id = wp_create_nav_menu( rand_str() );
+                $cat_menu_item = wp_update_nav_menu_item( $menu_id, 0, array(
+                        'menu-item-type' => 'taxonomy',
+                        'menu-item-object' => 'category',
+                        'menu-item-object-id' => $t1['term_id'],
+                        'menu-item-status' => 'publish'
+                ) );
+                $this->assertEquals( $t1['term_id'], get_post_meta( $cat_menu_item, '_menu_item_object_id', true ) );
+
+                $new_term_id = _split_shared_term( $t1['term_id'], $t1['term_taxonomy_id'] );
+                $this->assertNotEquals( $new_term_id, $t1['term_id'] );
+                $this->assertEquals( $new_term_id, get_post_meta( $cat_menu_item, '_menu_item_object_id', true ) );
+        }
 }