Changeset 30495

Timestamp:

11/21/2014 03:19:53 AM (10 years ago)

Author:

johnbillion

Message:

Only output an optgroup for installed languages in wp_dropdown_languages() if translations are available.

See #30335

File:

• trunk/src/wp-includes/l10n.php (modified) (3 diffs)

trunk/src/wp-includes/l10n.php

@@ -906 +906 @@
     }
 
+    $translations_available = ( ! empty( $translations ) && $args['show_available_translations'] );
+
     printf( '<select name="%s" id="%s">', esc_attr( $args['name'] ), esc_attr( $args['id'] ) );
 
@@ -912 +914 @@
 
     // List installed languages.
-    if ( $args['show_available_translations'] ) {
+    if ( $translations_available ) {
         $structure[] = '<optgroup label="' . esc_attr_x( 'Installed', 'translations' ) . '">';
     }
@@ -925 +927 @@
         );
     }
-    if ( $args['show_available_translations'] ) {
+    if ( $translations_available ) {
         $structure[] = '</optgroup>';
     }
 
     // List available translations.
-    if ( ! empty( $translations ) && $args['show_available_translations'] ) {
+    if ( $translations_available ) {
         $structure[] = '<optgroup label="' . esc_attr_x( 'Available', 'translations' ) . '">';
         foreach ( $translations as $translation ) {