Changeset 30525 for trunk/tests/phpunit/tests/formatting/SeemsUtf8.php

Timestamp:

11/22/2014 08:56:23 PM (10 years ago)

Author:

boonebgorges

Message:

Repair the seems_utf8() tests that use Big5 encoding.

• Provide sample data that is actually encoded in Big5.
• Do some actual assertions against that data.

Props akumria.
Fixes #30455.

File:

• trunk/tests/phpunit/tests/formatting/SeemsUtf8.php (modified) (2 diffs)

trunk/tests/phpunit/tests/formatting/SeemsUtf8.php

@@ -11 +11 @@
      * @dataProvider utf8_strings
      */
-    function test_returns_true_for_utf8_strings( $utf8_string ) {
+    function test_returns_true_for_utf8_strings( $utf8_string ) {
         // from http://www.i18nguy.com/unicode-example.html
         $this->assertTrue( seems_utf8( $utf8_string ) );
@@ -29 +29 @@
      */
     function test_returns_false_for_non_utf8_strings( $big5_string ) {
-        $this->markTestIncomplete( 'This test does not have any assertions.' );
-
-        $big5 = $big5[0];
-        $strings = array(
-            "abc",
-            "123",
-            $big5
-        );
+        $this->assertFalse( seems_utf8( $big5_string ) );
     }
 
     function big5_strings() {
         // Get data from formatting/big5.txt
-        return array( array( 'incomplete' ) );
+        $big5_strings = file( DIR_TESTDATA . '/formatting/big5.txt' );
+        foreach ( $big5_strings as &$string ) {
+            $string = (array) trim( $string );
+        }
+        unset( $string );
+        return $big5_strings;
     }
 }