Changeset 30548 for trunk/tests/phpunit/tests/comment/query.php

Timestamp:

11/24/2014 02:55:49 PM (10 years ago)

Author:

boonebgorges

Message:

Declare an explicit 'order' in test_get_comments_by_user().

This change fixes broken builds on older versions of MySQL. See #30462.

Assertions regarding indeterminate secondary ORDER BY clauses will go in
separate test methods. See #30478.

File:

• trunk/tests/phpunit/tests/comment/query.php (modified) (2 diffs)

trunk/tests/phpunit/tests/comment/query.php

@@ -640 +640 @@
         $this->factory->comment->create( array( 'user_id' => $users[1], 'comment_post_ID' => $this->post_id, 'comment_approved' => '1' ) );
 
-        $comments = get_comments( array( 'user_id' => $users[0] ) );
+        $comments = get_comments( array(
+            'user_id' => $users[0],
+            'orderby' => 'comment_ID',
+            'order' => 'ASC',
+        ) );
 
         $this->assertCount( 2, $comments );
@@ -646 +650 @@
         $this->assertEquals( $users[0], $comments[1]->user_id );
 
-        $comments = get_comments( array( 'user_id' => $users ) );
+        $comments = get_comments( array(
+            'user_id' => $users,
+            'orderby' => 'comment_ID',
+            'order' => 'ASC',
+        ) );
 
         $this->assertCount( 3, $comments );