Changeset 30687 for trunk/tests/phpunit/includes/testcase.php

Timestamp:

12/01/2014 05:01:29 AM (10 years ago)

Author:

pento

Message:

Unit Tests: The assertEqualSets() helper was returning true for some sets that were not equal. assertEqualSets() now behaves correctly, and the new assertEqualSetsWithIndex() helper also checks that the array indexes are the same.

Fixes #30522.

File:

• trunk/tests/phpunit/includes/testcase.php (modified) (1 diff)

trunk/tests/phpunit/includes/testcase.php

@@ -263 +263 @@
 
     function assertEqualSets( $expected, $actual ) {
-        $this->assertEquals( array(), array_diff( $expected, $actual ) );
-        $this->assertEquals( array(), array_diff( $actual, $expected ) );
+        sort( $expected );
+        sort( $actual );
+        $this->assertEquals( $expected, $actual );
+    }
+
+    function assertEqualSetsWithIndex( $expected, $actual ) {
+        ksort( $expected );
+        ksort( $actual );
+        $this->assertEquals( $expected, $actual );
     }