Changeset 30848

Timestamp:

12/14/2014 07:30:40 PM (10 years ago)

Author:

johnbillion

Message:

In WP_Meta_Query, interpret 'value' correctly when used with EXISTS/NOT EXISTS.

As in earlier versions, EXISTS with a value is equivalent to '=', while NOT
EXISTS should always ignore 'value'.

Merges [30846] to the 4.1 branch.

Props barrykooij.
Fixes #30681

Location:

branches/4.1

Files:

• . (modified) (1 prop)
• src/wp-includes/meta.php (modified) (1 diff)
• tests/phpunit/tests/post/query.php (modified) (1 diff)

branches/4.1/src/wp-includes/meta.php

@@ -1420 +1420 @@
                     break;
 
+                // EXISTS with a value is interpreted as '='.
+                case 'EXISTS' :
+                    $meta_compare = '=';
+                    $where = $wpdb->prepare( '%s', $meta_value );
+                    break;
+
+                // 'value' is ignored for NOT EXISTS.
+                case 'NOT EXISTS' :
+                    $where = '';
+                    break;
+
                 default :
                     $where = $wpdb->prepare( '%s', $meta_value );

branches/4.1/tests/phpunit/tests/post/query.php

@@ -539 +539 @@
 
     /**
+     * @ticket 30681
+     */
+    public function test_meta_query_compare_exists() {
+        $posts = $this->factory->post->create_many( 3 );
+        add_post_meta( $posts[0], 'foo', 'bar' );
+        add_post_meta( $posts[2], 'foo', 'baz' );
+
+        $query = new WP_Query( array(
+            'fields' => 'ids',
+            'meta_query' => array(
+                array(
+                    'compare' => 'EXISTS',
+                    'key' => 'foo',
+                ),
+            ),
+        ) );
+
+        $this->assertEqualSets( array( $posts[0], $posts[2] ), $query->posts );
+    }
+
+    /**
+     * @ticket 30681
+     */
+    public function test_meta_query_compare_exists_with_value_should_convert_to_equals() {
+        $posts = $this->factory->post->create_many( 3 );
+        add_post_meta( $posts[0], 'foo', 'bar' );
+        add_post_meta( $posts[2], 'foo', 'baz' );
+
+        $query = new WP_Query( array(
+            'fields' => 'ids',
+            'meta_query' => array(
+                array(
+                    'compare' => 'EXISTS',
+                    'value' => 'baz',
+                    'key' => 'foo',
+                ),
+            ),
+        ) );
+
+        $this->assertEqualSets( array( $posts[2] ), $query->posts );
+    }
+
+    /**
+     * @ticket 30681
+     */
+    public function test_meta_query_compare_not_exists_should_ignore_value() {
+        $posts = $this->factory->post->create_many( 3 );
+        add_post_meta( $posts[0], 'foo', 'bar' );
+        add_post_meta( $posts[2], 'foo', 'baz' );
+
+        $query = new WP_Query( array(
+            'fields' => 'ids',
+            'meta_query' => array(
+                array(
+                    'compare' => 'NOT EXISTS',
+                    'value' => 'bar',
+                    'key' => 'foo',
+                ),
+            ),
+        ) );
+
+        $this->assertEqualSets( array( $posts[1] ), $query->posts );
+    }
+
+    /**
      * @ticket 18158
      * @group meta