Changeset 30908

Timestamp:

12/16/2014 03:51:54 PM (10 years ago)

Author:

johnbillion

Message:

Do not autofocus text fields on page load on mobile devices. This is currently broken in many mobile browsers:

• iOS Safari opens the keyboard and auto-scrolls on the first tap anywhere on the screen triggering the click at an unexpected place. That makes it impossible to follow links or press buttons.
• Chrome on iOS opens the keyboard on load and may scroll the focused field off screen.
• The Android 4.4 browser only highlights the field, the user has to tap it to open the keyboard and type.

Merges [30842] to the 4.1 branch.

See #30703.

Location:

branches/4.1

Files:

• . (modified) (1 prop)
• src/wp-admin/edit-form-advanced.php (modified) (1 diff)
• src/wp-admin/edit-form-comment.php (modified) (1 diff)
• src/wp-admin/edit-tag-form.php (modified) (1 diff)
• src/wp-admin/edit-tags.php (modified) (1 diff)

branches/4.1/src/wp-admin/edit-form-advanced.php

@@ -648 +648 @@
 ?>
 
-<?php if ( post_type_supports( $post_type, 'title' ) && '' === $post->post_title ) : ?>
+<?php if ( ! wp_is_mobile() && post_type_supports( $post_type, 'title' ) && '' === $post->post_title ) : ?>
 <script type="text/javascript">
 try{document.post.title.focus();}catch(e){}

branches/4.1/src/wp-admin/edit-form-comment.php

@@ -156 +156 @@
 </form>
 
+<?php if ( ! wp_is_mobile() ) : ?>
 <script type="text/javascript">
 try{document.post.name.focus();}catch(e){}
 </script>
+<?php endif;

branches/4.1/src/wp-admin/edit-tag-form.php

@@ -201 +201 @@
 </form>
 </div>
+
+<?php if ( ! wp_is_mobile() ) : ?>
 <script type="text/javascript">
 try{document.forms.edittag.name.focus();}catch(e){}
 </script>
+<?php endif;

branches/4.1/src/wp-admin/edit-tags.php

@@ -584 +584 @@
 </div><!-- /col-container -->
 </div><!-- /wrap -->
+
+<?php if ( ! wp_is_mobile() ) : ?>
 <script type="text/javascript">
 try{document.forms.addtag['tag-name'].focus();}catch(e){}
 </script>
 <?php
+endif;
+
 $wp_list_table->inline_edit();