Changeset 30991

Timestamp:

12/23/2014 05:04:47 PM (10 years ago)

Author:

ocean90

Message:

Customizer: Improve IE 8 compatibility.

• Use square bracket notation for default keywords.
• Use Underscores indexOf for arrays.

props westonruter, ocean90.
fixes #30781 for trunk.

Location:

trunk/src

Files:

• wp-admin/js/customize-controls.js (modified) (1 diff)
• wp-includes/class-wp-customize-control.php (modified) (3 diffs)

trunk/src/wp-admin/js/customize-controls.js

@@ -129 +129 @@
         var equal = (
             listA.length === listB.length && // if lists are different lengths, then naturally they are not equal
-            -1 === _.map( // are there any false values in the list returned by map?
+            -1 === _.indexOf( _.map( // are there any false values in the list returned by map?
                 _.zip( listA, listB ), // pair up each element between the two lists
                 function ( pair ) {
                     return $( pair[0] ).is( pair[1] ); // compare to see if each pair are equal
                 }
-            ).indexOf( false ) // check for presence of false in map's return value
+            ), false ) // check for presence of false in map's return value
         );
         return equal;

trunk/src/wp-includes/class-wp-customize-control.php

@@ -739 +739 @@
     public function content_template() {
         ?>
-        <label for="{{ data.settings.default }}-button">
+        <label for="{{ data.settings['default'] }}-button">
             <# if ( data.label ) { #>
                 <span class="customize-control-title">{{ data.label }}</span>
@@ -776 +776 @@
             <div class="actions">
                 <button type="button" class="button remove-button"><?php echo $this->button_labels['remove']; ?></button>
-                <button type="button" class="button upload-button" id="{{ data.settings.default }}-button"><?php echo $this->button_labels['change']; ?></button>
+                <button type="button" class="button upload-button" id="{{ data.settings['default'] }}-button"><?php echo $this->button_labels['change']; ?></button>
                 <div style="clear:both"></div>
             </div>
@@ -795 +795 @@
                     <button type="button" class="button default-button"><?php echo $this->button_labels['default']; ?></button>
                 <# } #>
-                <button type="button" class="button upload-button" id="{{ data.settings.default }}-button"><?php echo $this->button_labels['select']; ?></button>
+                <button type="button" class="button upload-button" id="{{ data.settings['default'] }}-button"><?php echo $this->button_labels['select']; ?></button>
                 <div style="clear:both"></div>
             </div>