Changeset 31003

Timestamp:

12/30/2014 07:30:07 PM (10 years ago)

Author:

boonebgorges

Message:

When no plugins are active, return an empty array from validate_active_plugins().

This creates parity with the behavior of the function when plugins *are* active,
but none are invalid. It also makes it possible to write unit tests for the
function.

Props sgrant.
Fixes #30860.

Location:

trunk

Files:

• src/wp-admin/includes/plugin.php (modified) (1 diff)
• tests/phpunit/tests/admin/includesPlugin.php (modified) (1 diff)

trunk/src/wp-admin/includes/plugin.php

@@ -885 +885 @@
 
     if ( empty( $plugins ) )
-        return;
+        return array();
 
     $invalid = array();

trunk/tests/phpunit/tests/admin/includesPlugin.php

@@ -294 +294 @@
 
     /**
+     * @covers ::validate_active_plugins
+     */
+    public function test_validate_active_plugins_empty() {
+        $this->assertEquals( array(), validate_active_plugins() );
+    }
+
+    /**
      * @covers ::is_uninstallable_plugin
      */