Changeset 31019 for trunk

Timestamp:

01/01/2015 07:54:53 PM (10 years ago)

Author:

wonderboymusic

Message:

WP_List_Table's constructor registers an 'admin_footer' callback when AJAX is enabled. As such, if you create multiple instances of the class, you get multiple JS blobs on the page when the callbacks fire. Extra instances get made when wp_comment_reply() invokes the class constructor without checking for the existing instance via the $wp_list_table global.

We shall check the $wp_list_table global in wp_comment_reply().

Props sorich87.
Fixes #17413.

File:

• trunk/src/wp-admin/includes/template.php (modified) (2 diffs)

trunk/src/wp-admin/includes/template.php

@@ -413 +413 @@
  */
 function wp_comment_reply($position = '1', $checkbox = false, $mode = 'single', $table_row = true) {
-
+    global $wp_list_table;
     /**
      * Filter the in-line comment reply-to form output in the Comments
@@ -436 +436 @@
     }
 
-    if ( $mode == 'single' ) {
-        $wp_list_table = _get_list_table('WP_Post_Comments_List_Table');
-    } else {
-        $wp_list_table = _get_list_table('WP_Comments_List_Table');
+    if ( ! $wp_list_table ) {
+        if ( $mode == 'single' ) {
+            $wp_list_table = _get_list_table('WP_Post_Comments_List_Table');
+        } else {
+            $wp_list_table = _get_list_table('WP_Comments_List_Table');
+        }
     }