Changeset 31078 for trunk/src/wp-includes/rewrite.php

Timestamp:

01/08/2015 05:43:54 AM (10 years ago)

Author:

wonderboymusic

Message:

Access Modifiers:

• In WP_Plugin_Install_List_Table, use public instead of var
• In WP_User, ->data is accessed directly on an instance if the constructor receives it: make it public
• In WP_Locale, every property is exported to a global and is already public via var, half of the properties are accessed directly already, make them all public
• In WP_Rewrite, several properties are accessed publicly in functions via the $wp_rewrite global, make those props public.
• In WP_Rewrite, the property ->comment_feed_structure was misspelled as ->comments_feed_structure

See #30799.

File:

• trunk/src/wp-includes/rewrite.php (modified) (11 diffs)

trunk/src/wp-includes/rewrite.php

@@ -421 +421 @@
      *
      * @since 1.5.0
+     * @var string
+     */
+    public $permalink_structure;
+
+    /**
+     * Whether to add trailing slashes.
+     *
+     * @since 2.2.0
+     * @var bool
+     */
+    public $use_trailing_slashes;
+
+    /**
+     * Base for the author permalink structure (example.com/$author_base/authorname).
+     *
+     * @since 1.5.0
      * @access private
      * @var string
      */
-    var $permalink_structure;
-
-    /**
-     * Whether to add trailing slashes.
-     *
-     * @since 2.2.0
-     * @access private
-     * @var bool
-     */
-    var $use_trailing_slashes;
-
-    /**
-     * Base for the author permalink structure (example.com/$author_base/authorname).
+    var $author_base = 'author';
+
+    /**
+     * Permalink structure for author archives.
      *
      * @since 1.5.0
@@ -442 +449 @@
      * @var string
      */
-    var $author_base = 'author';
-
-    /**
-     * Permalink structure for author archives.
+    var $author_structure;
+
+    /**
+     * Permalink structure for date archives.
      *
      * @since 1.5.0
@@ -451 +458 @@
      * @var string
      */
-    var $author_structure;
-
-    /**
-     * Permalink structure for date archives.
+    var $date_structure;
+
+    /**
+     * Permalink structure for pages.
      *
      * @since 1.5.0
@@ -460 +467 @@
      * @var string
      */
-    var $date_structure;
-
-    /**
-     * Permalink structure for pages.
+    var $page_structure;
+
+    /**
+     * Base of the search permalink structure (example.com/$search_base/query).
      *
      * @since 1.5.0
@@ -469 +476 @@
      * @var string
      */
-    var $page_structure;
-
-    /**
-     * Base of the search permalink structure (example.com/$search_base/query).
+    var $search_base = 'search';
+
+    /**
+     * Permalink structure for searches.
      *
      * @since 1.5.0
@@ -478 +485 @@
      * @var string
      */
-    var $search_base = 'search';
-
-    /**
-     * Permalink structure for searches.
+    var $search_structure;
+
+    /**
+     * Comments permalink base.
      *
      * @since 1.5.0
@@ -487 +494 @@
      * @var string
      */
-    var $search_structure;
-
-    /**
-     * Comments permalink base.
+    var $comments_base = 'comments';
+
+    /**
+     * Pagination permalink base.
+     *
+     * @since 3.1.0
+     * @var string
+     */
+    public $pagination_base = 'page';
+
+    /**
+     * Feed permalink base.
      *
      * @since 1.5.0
@@ -496 +511 @@
      * @var string
      */
-    var $comments_base = 'comments';
-
-    /**
-     * Pagination permalink base.
-     *
-     * @since 3.1.0
+    var $feed_base = 'feed';
+
+    /**
+     * Comments feed permalink structure.
+     *
+     * @since 1.5.0
      * @access private
      * @var string
      */
-    var $pagination_base = 'page';
-
-    /**
-     * Feed permalink base.
-     *
-     * @since 1.5.0
-     * @access private
-     * @var string
-     */
-    var $feed_base = 'feed';
-
-    /**
-     * Comments feed permalink structure.
-     *
-     * @since 1.5.0
-     * @access private
-     * @var string
-     */
-    var $comments_feed_structure;
+    var $comment_feed_structure;
 
     /**
@@ -543 +540 @@
      * @see WP_Rewrite::init()
      * @since 1.5.0
-     * @access private
      * @var string
      */
-    var $front;
+    public $front;
 
     /**
@@ -558 +554 @@
      * @see WP_Rewrite::using_index_permalinks()
      * @since 1.5.0
-     * @access private
      * @var string
      */
-    var $root = '';
+    public $root = '';
 
     /**
@@ -747 +742 @@
      *
      * @since 1.5.0
-     * @access private
      * @var array
      */
-    var $feeds = array( 'feed', 'rdf', 'rss', 'rss2', 'atom' );
+    public $feeds = array( 'feed', 'rdf', 'rss', 'rss2', 'atom' );
 
     /**