Changeset 31083

Timestamp:

01/08/2015 06:01:08 AM (12 years ago)

Author:

wonderboymusic

Message:

In Customizer classes:

• public final function methods should be final public function - confusing Hack and aligns with PSR2
• Some methods were missing access modifiers

See #30799.

Location:

trunk/src/wp-includes

Files:

• class-oembed.php (modified) (1 diff)
• class-wp-customize-control.php (modified) (7 diffs)
• class-wp-customize-panel.php (modified) (4 diffs)
• class-wp-customize-section.php (modified) (4 diffs)
• class-wp-customize-setting.php (modified) (3 diffs)

trunk/src/wp-includes/class-oembed.php

@@ -273 +273 @@
          * @return false|string False on failure, otherwise the UNSANITIZED (and potentially unsafe) HTML that should be used to embed.
          */
-        function get_html( $url, $args = '' ) {
+        public function get_html( $url, $args = '' ) {
                 $provider = $this->get_provider( $url, $args );
 

trunk/src/wp-includes/class-wp-customize-control.php

@@ -184 +184 @@
          * @return bool Whether the control is active to the current preview.
          */
-        public final function active() {
+        final public function active() {
                 $control = $this;
                 $active = call_user_func( $this->active_callback, $this );
@@ -225 +225 @@
          * @return mixed The requested setting's value, if the setting exists.
          */
-        public final function value( $setting_key = 'default' ) {
+        final public function value( $setting_key = 'default' ) {
                 if ( isset( $this->settings[ $setting_key ] ) ) {
                         return $this->settings[ $setting_key ]->value();
@@ -271 +271 @@
          * @return bool False if theme doesn't support the control or user doesn't have the required permissions, otherwise true.
          */
-        public final function check_capabilities() {
+        final public function check_capabilities() {
                 foreach ( $this->settings as $setting ) {
                         if ( ! $setting->check_capabilities() )
@@ -291 +291 @@
          * @return string Contents of the control.
          */
-        public final function get_content() {
+        final public function get_content() {
                 ob_start();
                 $this->maybe_render();
@@ -305 +305 @@
          * @uses WP_Customize_Control::render()
          */
-        public final function maybe_render() {
+        final public function maybe_render() {
                 if ( ! $this->check_capabilities() )
                         return;
@@ -976 +976 @@
         }
 
-        function print_header_image_template() {
+        public function print_header_image_template() {
                 ?>
                 <script type="text/template" id="tmpl-header-choice">
@@ -1186 +1186 @@
          * @return bool Whether the widget is rendered.
          */
-        function active_callback() {
+        public function active_callback() {
                 return $this->manager->widgets->is_widget_rendered( $this->widget_id );
         }

trunk/src/wp-includes/class-wp-customize-panel.php

@@ -167 +167 @@
          * @return bool Whether the panel is active to the current preview.
          */
-        public final function active() {
+        final public function active() {
                 $panel = $this;
                 $active = call_user_func( $this->active_callback, $this );
@@ -222 +222 @@
          * @return bool False if theme doesn't support the panel or the user doesn't have the capability.
          */
-        public final function check_capabilities() {
+        final public function check_capabilities() {
                 if ( $this->capability && ! call_user_func_array( 'current_user_can', (array) $this->capability ) ) {
                         return false;
@@ -241 +241 @@
          * @return string Content for the panel.
          */
-        public final function get_content() {
+        final public function get_content() {
                 ob_start();
                 $this->maybe_render();
@@ -254 +254 @@
          * @since 4.0.0
          */
-        public final function maybe_render() {
+        final public function maybe_render() {
                 if ( ! $this->check_capabilities() ) {
                         return;

trunk/src/wp-includes/class-wp-customize-section.php

@@ -176 +176 @@
          * @return bool Whether the section is active to the current preview.
          */
-        public final function active() {
+        final public function active() {
                 $section = $this;
                 $active = call_user_func( $this->active_callback, $this );
@@ -231 +231 @@
          * @return bool False if theme doesn't support the section or user doesn't have the capability.
          */
-        public final function check_capabilities() {
+        final public function check_capabilities() {
                 if ( $this->capability && ! call_user_func_array( 'current_user_can', (array) $this->capability ) ) {
                         return false;
@@ -250 +250 @@
          * @return string Contents of the section.
          */
-        public final function get_content() {
+        final public function get_content() {
                 ob_start();
                 $this->maybe_render();
@@ -263 +263 @@
          * @since 3.4.0
          */
-        public final function maybe_render() {
+        final public function maybe_render() {
                 if ( ! $this->check_capabilities() ) {
                         return;

trunk/src/wp-includes/class-wp-customize-setting.php

@@ -171 +171 @@
          * @return false|null False if cap check fails or value isn't set.
          */
-        public final function save() {
+        final public function save() {
                 $value = $this->post_value();
 
@@ -200 +200 @@
          * @return mixed The default value on failure, otherwise the sanitized value.
          */
-        public final function post_value( $default = null ) {
+        final public function post_value( $default = null ) {
                 // Check for a cached value
                 if ( isset( $this->_post_value ) )
@@ -386 +386 @@
          * @return bool False if theme doesn't support the setting or user can't change setting, otherwise true.
          */
-        public final function check_capabilities() {
+        final public function check_capabilities() {
                 if ( $this->capability && ! call_user_func_array( 'current_user_can', (array) $this->capability ) )
                         return false;