Changeset 31125

Timestamp:

01/10/2015 06:12:25 AM (10 years ago)

Author:

wonderboymusic

Message:

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value - anything that is returned is discarded.

See #30799.

Location:

trunk/src/wp-admin

Files:

• custom-background.php (modified) (1 diff)
• custom-header.php (modified) (1 diff)
• includes/class-wp-filesystem-ftpext.php (modified) (1 diff)
• includes/class-wp-filesystem-ssh2.php (modified) (1 diff)
• includes/class-wp-importer.php (modified) (1 diff)

trunk/src/wp-admin/custom-background.php

@@ -54 +54 @@
      * @param callback $admin_header_callback
      * @param callback $admin_image_div_callback Optional custom image div output callback.
-     * @return Custom_Background
      */
     public function __construct($admin_header_callback = '', $admin_image_div_callback = '') {

trunk/src/wp-admin/custom-header.php

@@ -72 +72 @@
      * @param callback $admin_header_callback
      * @param callback $admin_image_div_callback Optional custom image div output callback.
-     * @return Custom_Image_Header
      */
     public function __construct($admin_header_callback, $admin_image_div_callback = '') {

trunk/src/wp-admin/includes/class-wp-filesystem-ftpext.php

@@ -27 +27 @@
         if ( ! extension_loaded('ftp') ) {
             $this->errors->add('no_ftp_ext', __('The ftp PHP extension is not available'));
-            return false;
+            return;
         }
 

trunk/src/wp-admin/includes/class-wp-filesystem-ssh2.php

@@ -49 +49 @@
         if ( ! extension_loaded('ssh2') ) {
             $this->errors->add('no_ssh2_ext', __('The ssh2 PHP extension is not available'));
-            return false;
+            return;
         }
         if ( !function_exists('stream_get_contents') ) {
             $this->errors->add('ssh2_php_requirement', __('The ssh2 PHP extension is available, however, we require the PHP5 function <code>stream_get_contents()</code>'));
-            return false;
+            return;
         }
 

trunk/src/wp-admin/includes/class-wp-importer.php

@@ -7 +7 @@
      * Class Constructor
      *
-     * @return void
      */
     public function __construct() {}