Changeset 31129

Timestamp:

01/10/2015 08:43:12 PM (10 years ago)

Author:

wonderboymusic

Message:

Since get_theme_mod() returns false on failure, $background_image_thumb can be set to it and checked instead of calling get_background_image() 3 times in Custom_Background->admin_page().

See #30799.

File:

• trunk/src/wp-admin/custom-background.php (modified) (2 diffs)

trunk/src/wp-admin/custom-background.php

@@ -279 +279 @@
             $background_styles .= 'background-color: #' . $bgcolor . ';';
 
-        if ( get_background_image() ) {
-            $background_image_thumb = esc_url( set_url_scheme( get_theme_mod( 'background_image_thumb', str_replace( '%', '%%', get_background_image() ) ) ) );
+        $background_image_thumb = get_background_image();
+        if ( $background_image_thumb ) {
+            $background_image_thumb = esc_url( set_url_scheme( get_theme_mod( 'background_image_thumb', str_replace( '%', '%%', $background_image_thumb ) ) ) );
 
             // Background-image URL must be single quote, see below.
@@ -289 +290 @@
     ?>
     <div id="custom-background-image" style="<?php echo $background_styles; ?>"><?php // must be double quote, see above ?>
-        <?php if ( get_background_image() ) { ?>
+        <?php if ( $background_image_thumb ) { ?>
         <img class="custom-background-image" src="<?php echo $background_image_thumb; ?>" style="visibility:hidden;" alt="" /><br />
         <img class="custom-background-image" src="<?php echo $background_image_thumb; ?>" style="visibility:hidden;" alt="" />