Changeset 31137 for trunk/src/wp-includes/class-wp-walker.php

Timestamp:

01/10/2015 11:43:43 PM (12 years ago)

Author:

wonderboymusic

Message:

In Walker:

• Every subclass of Walker overrides $db_fields and makes it public
• wp_list_comments() accesses ->max_pages on an instance of Walker, it must be public
• $has_children was added as protected in 4.0. doesn't need BC

Make $db_fields and $max_pages public and remove magic methods.

See #30891.

File:

• trunk/src/wp-includes/class-wp-walker.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-walker.php

@@ -26 +26 @@
          *
          * @since 2.1.0
-         * @access protected
          * @var array
          */
-        protected $db_fields;
+        public $db_fields;
 
         /**
@@ -35 +34 @@
          *
          * @since 2.7.0
-         * @access protected
          * @var int
          */
-        protected $max_pages = 1;
+        public $max_pages = 1;
 
         /**
@@ -50 +48 @@
          */
         protected $has_children;
-
-        /**
-         * Make private properties readable for backwards compatibility.
-         *
-         * @since 4.0.0
-         * @access public
-         *
-         * @param string $name Property to get.
-         * @return mixed Property.
-         */
-        public function __get( $name ) {
-                return $this->$name;
-        }
-
-        /**
-         * Make private properties settable for backwards compatibility.
-         *
-         * @since 4.0.0
-         * @access public
-         *
-         * @param string $name  Property to set.
-         * @param mixed  $value Property value.
-         * @return mixed Newly-set property.
-         */
-        public function __set( $name, $value ) {
-                return $this->$name = $value;
-        }
-
-        /**
-         * Make private properties checkable for backwards compatibility.
-         *
-         * @since 4.0.0
-         * @access public
-         *
-         * @param string $name Property to check if set.
-         * @return bool Whether the property is set.
-         */
-        public function __isset( $name ) {
-                return isset( $this->$name );
-        }
-
-        /**
-         * Make private properties un-settable for backwards compatibility.
-         *
-         * @since 4.0.0
-         * @access public
-         *
-         * @param string $name Property to unset.
-         */
-        public function __unset( $name ) {
-                unset( $this->$name );
-        }
 
         /**