Changeset 31138

Timestamp:

01/11/2015 12:00:05 AM (11 years ago)

Author:

wonderboymusic

Message:

In WP_Error:

• wp_send_json_error() accesses $errors on an instance, it must be public
• $error_data is a local message cache for error codes and doesn't particularly hide info, would be the only non-public field or method in the class

Make $errors and $error_data public and remove magic methods.

See #30891.

File:

• trunk/src/wp-includes/class-wp-error.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-error.php

@@ -25 +25 @@
      * @since 2.1.0
      * @var array
-     * @access private
-     */
-    private $errors = array();
+     */
+    public $errors = array();
 
     /**
@@ -34 +33 @@
      * @since 2.1.0
      * @var array
-     * @access private
-     */
-    private $error_data = array();
+     */
+    public $error_data = array();
 
     /**
@@ -63 +61 @@
         if ( ! empty($data) )
             $this->error_data[$code] = $data;
-    }
-
-    /**
-     * Make private properties readable for backwards compatibility.
-     *
-     * @since 4.0.0
-     * @access public
-     *
-     * @param string $name Property to get.
-     * @return mixed Property.
-     */
-    public function __get( $name ) {
-        return $this->$name;
-    }
-
-    /**
-     * Make private properties settable for backwards compatibility.
-     *
-     * @since 4.0.0
-     * @access public
-     *
-     * @param string $name  Property to set.
-     * @param mixed  $value Property value.
-     * @return mixed Newly-set property.
-     */
-    public function __set( $name, $value ) {
-        return $this->$name = $value;
-    }
-
-    /**
-     * Make private properties checkable for backwards compatibility.
-     *
-     * @since 4.0.0
-     * @access public
-     *
-     * @param string $name Property to check if set.
-     * @return bool Whether the property is set.
-     */
-    public function __isset( $name ) {
-        return isset( $this->$name );
-    }
-
-    /**
-     * Make private properties un-settable for backwards compatibility.
-     *
-     * @since 4.0.0
-     * @access public
-     *
-     * @param string $name Property to unset.
-     */
-    public function __unset( $name ) {
-        unset( $this->$name );
     }