Changeset 31139 for trunk/src/wp-includes/class-wp-ajax-response.php

Timestamp:

01/11/2015 12:12:47 AM (10 years ago)

Author:

wonderboymusic

Message:

WP_Ajax_Response has one property only, $responses. It was public until [28508], when it became private in name only. Is it worth 4 magic methods to pretend that this property is private? It is not.

Make it public and remove the magic methods.

See #30891.

File:

• trunk/src/wp-includes/class-wp-ajax-response.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-ajax-response.php

@@ -12 +12 @@
      * @since 2.1.0
      * @var array
-     * @access private
      */
-    private $responses = array();
+    public $responses = array();
 
     /**
@@ -27 +26 @@
         if ( !empty($args) )
             $this->add($args);
-    }
-
-    /**
-     * Make private properties readable for backwards compatibility.
-     *
-     * @since 4.0.0
-     * @access public
-     *
-     * @param string $name Property to get.
-     * @return mixed Property.
-     */
-    public function __get( $name ) {
-        return $this->$name;
-    }
-
-    /**
-     * Make private properties settable for backwards compatibility.
-     *
-     * @since 4.0.0
-     * @access public
-     *
-     * @param string $name  Property to set.
-     * @param mixed  $value Property value.
-     * @return mixed Newly-set property.
-     */
-    public function __set( $name, $value ) {
-        return $this->$name = $value;
-    }
-
-    /**
-     * Make private properties checkable for backwards compatibility.
-     *
-     * @since 4.0.0
-     * @access public
-     *
-     * @param string $name Property to check if set.
-     * @return bool Whether the property is set.
-     */
-    public function __isset( $name ) {
-        return isset( $this->$name );
-    }
-
-    /**
-     * Make private properties un-settable for backwards compatibility.
-     *
-     * @since 4.0.0
-     * @access public
-     *
-     * @param string $name Property to unset.
-     */
-    public function __unset( $name ) {
-        unset( $this->$name );
     }