Changeset 31146

Timestamp:

01/11/2015 10:19:58 PM (10 years ago)

Author:

wonderboymusic

Message:

In WP_List_Table, only call magic method internals again whitelists of properties and methods, $compat_fields and $compat_methods.

See #30891.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (6 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -80 +80 @@
      */
     protected $_column_headers;
+
+    protected $compat_fields = array( '_args', '_pagination_args', 'screen', '_actions', '_pagination' );
+
+    protected $compat_methods = array( 'set_pagination_args', 'get_views', 'get_bulk_actions', 'bulk_actions',
+        'row_actions', 'months_dropdown', 'view_switcher', 'comments_bubble', 'get_items_per_page', 'pagination',
+        'get_sortable_columns', 'get_column_info', 'get_table_classes', 'display_tablenav', 'extra_tablenav',
+        'single_row_columns' );
 
     /**
@@ -150 +157 @@
      */
     public function __get( $name ) {
-        return $this->$name;
+        if ( in_array( $name, $this->compat_fields ) ) {
+            return $this->$name;
+        }
     }
 
@@ -159 +168 @@
      * @access public
      *
-     * @param string $name  Property to set.
+     * @param string $name  Property to check if set.
      * @param mixed  $value Property value.
      * @return mixed Newly-set property.
      */
     public function __set( $name, $value ) {
-        return $this->$name = $value;
+        if ( in_array( $name, $this->compat_fields ) ) {
+            return $this->$name = $value;
+        }
     }
 
@@ -177 +188 @@
      */
     public function __isset( $name ) {
-        return isset( $this->$name );
+        if ( in_array( $name, $this->compat_fields ) ) {
+            return isset( $this->$name );
+        }
     }
 
@@ -189 +202 @@
      */
     public function __unset( $name ) {
-        unset( $this->$name );
+        if ( in_array( $name, $this->compat_fields ) ) {
+            unset( $this->$name );
+        }
     }
 
@@ -203 +218 @@
      */
     public function __call( $name, $arguments ) {
-        return call_user_func_array( array( $this, $name ), $arguments );
+        if ( in_array( $name, $this->compat_methods ) ) {
+            return call_user_func_array( array( $this, $name ), $arguments );
+        }
+        return false;
     }