WordPress.org

Make WordPress Core


Ignore:
Timestamp:
01/12/2015 04:39:39 PM (7 years ago)
Author:
wonderboymusic
Message:

There are some random add_action() and add_filter() calls littered around some files in wp-includes/. These should be moved to wp-includes/default-filters.php with the rest of the registered hooks. It seems like this was the best practice for awhile and then we randomly stopped. This file loads way before any of the includes, so the hooks will be registered for any request that loads WordPress, even SHORTINIT - a lot of the hooks registered won't run anyways (that's already the case).

See #30947.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/default-filters.php

    r30585 r31168  
    307307add_filter( 'determine_current_user', 'wp_validate_logged_in_cookie', 20 );
    308308
    309 unset($filter, $action);
     309/**
     310 * Filters formerly mixed into wp-includes
     311 */
     312// Theme
     313add_action( 'setup_theme', 'preview_theme' );
     314add_action( 'wp_loaded', '_custom_header_background_just_in_time' );
     315add_action( 'plugins_loaded', '_wp_customize_include' );
     316add_action( 'admin_enqueue_scripts', '_wp_customize_loader_settings' );
     317add_action( 'delete_attachment', '_delete_attachment_theme_mod' );
     318
     319// Calendar widget cache
     320add_action( 'save_post', 'delete_get_calendar_cache' );
     321add_action( 'delete_post', 'delete_get_calendar_cache' );
     322add_action( 'update_option_start_of_week', 'delete_get_calendar_cache' );
     323add_action( 'update_option_gmt_offset', 'delete_get_calendar_cache' );
     324
     325// Author
     326add_action( 'transition_post_status', '__clear_multi_author_cache' );
     327
     328// Post
     329add_action( 'init', 'create_initial_post_types', 0 ); // highest priority
     330add_action( 'admin_menu', '_add_post_type_submenus' );
     331add_action( 'before_delete_post', '_reset_front_page_settings_for_post' );
     332add_action( 'wp_trash_post',      '_reset_front_page_settings_for_post' );
     333
     334// Post Formats
     335add_filter( 'request', '_post_format_request' );
     336add_filter( 'term_link', '_post_format_link', 10, 3 );
     337add_filter( 'get_post_format', '_post_format_get_term' );
     338add_filter( 'get_terms', '_post_format_get_terms', 10, 3 );
     339add_filter( 'wp_get_object_terms', '_post_format_wp_get_object_terms' );
     340
     341// KSES
     342add_action( 'init', 'kses_init' );
     343add_action( 'set_current_user', 'kses_init' );
     344
     345// Script Loader
     346add_action( 'wp_default_scripts', 'wp_default_scripts' );
     347add_filter( 'wp_print_scripts', 'wp_just_in_time_script_localization' );
     348add_filter( 'print_scripts_array', 'wp_prototype_before_jquery' );
     349
     350add_action( 'wp_default_styles', 'wp_default_styles' );
     351add_filter( 'style_loader_src', 'wp_style_loader_src', 10, 2 );
     352
     353// Taxonomy
     354add_action( 'init', 'create_initial_taxonomies', 0 ); // highest priority
     355
     356// Update
     357add_action( 'admin_init', '_maybe_update_core' );
     358add_action( 'wp_version_check', 'wp_version_check' );
     359add_action( 'upgrader_process_complete', 'wp_version_check', 10, 0 );
     360add_action( 'load-plugins.php', 'wp_update_plugins' );
     361add_action( 'load-update.php', 'wp_update_plugins' );
     362add_action( 'load-update-core.php', 'wp_update_plugins' );
     363add_action( 'admin_init', '_maybe_update_plugins' );
     364add_action( 'wp_update_plugins', 'wp_update_plugins' );
     365add_action( 'upgrader_process_complete', 'wp_update_plugins', 10, 0 );
     366add_action( 'load-themes.php', 'wp_update_themes' );
     367add_action( 'load-update.php', 'wp_update_themes' );
     368add_action( 'load-update-core.php', 'wp_update_themes' );
     369add_action( 'admin_init', '_maybe_update_themes' );
     370add_action( 'wp_update_themes', 'wp_update_themes' );
     371add_action( 'upgrader_process_complete', 'wp_update_themes', 10, 0 );
     372add_action( 'update_option_WPLANG', 'wp_clean_update_cache' , 10, 0 );
     373add_action( 'wp_maybe_auto_update', 'wp_maybe_auto_update' );
     374add_action( 'init', 'wp_schedule_update_checks' );
     375
     376// Canonical
     377add_action( 'template_redirect', 'redirect_canonical' );
     378add_action( 'template_redirect', 'wp_redirect_admin_locations', 1000 );
     379
     380// Shortcodes
     381add_filter( 'the_content', 'do_shortcode', 11 ); // AFTER wpautop()
     382
     383// Media
     384add_action( 'wp_playlist_scripts', 'wp_playlist_scripts' );
     385add_action( 'customize_controls_enqueue_scripts', 'wp_plupload_default_settings' );
     386
     387// Nav menu
     388add_filter( 'nav_menu_item_id', '_nav_menu_item_id_use_once', 10, 2 );
     389
     390// Admin Bar
     391// Don't remove. Wrong way to disable.
     392add_action( 'template_redirect', '_wp_admin_bar_init', 0 );
     393add_action( 'admin_init', '_wp_admin_bar_init' );
     394add_action( 'wp_footer', 'wp_admin_bar_render', 1000 );
     395add_action( 'in_admin_header', 'wp_admin_bar_render', 0 );
     396
     397unset( $filter, $action );
Note: See TracChangeset for help on using the changeset viewer.