Changeset 31181 for trunk/src/wp-admin/includes/class-wp-users-list-table.php

Timestamp:

01/14/2015 10:13:03 PM (10 years ago)

Author:

helen

Message:

List tables: Use CSS :nth-child() selectors for zebra striping.

Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the .alternate class for now. IE8 and below gracefully degrade by not having zebra striping.

There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.

fixes #30981 and #26060. see #25060.

File:

• trunk/src/wp-admin/includes/class-wp-users-list-table.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-users-list-table.php

@@ -307 +307 @@
         $editable_roles = array_keys( get_editable_roles() );
 
-        $style = '';
         foreach ( $this->items as $userid => $user_object ) {
             if ( count( $user_object->roles ) <= 1 ) {
@@ -320 +319 @@
                 continue;
 
-            $style = ( ' class="alternate"' == $style ) ? '' : ' class="alternate"';
-            echo "\n\t" . $this->single_row( $user_object, $style, $role, isset( $post_counts ) ? $post_counts[ $userid ] : 0 );
+            echo "\n\t" . $this->single_row( $user_object, $style = '', $role, isset( $post_counts ) ? $post_counts[ $userid ] : 0 );
         }
     }
@@ -329 +327 @@
      *
      * @since 3.1.0
+     * @since 4.2.0 `$style` argument was deprecated.
      * @access public
      *
      * @param object $user_object The current user object.
-     * @param string $style       Optional. Style attributes added to the `<tr>` element.
-     *                            Must be sanitized. Default empty.
+     * @param string $style       Deprecated. Not used.
      * @param string $role        Optional. Key for the $wp_roles array. Default empty.
      * @param int    $numposts    Optional. Post count to display for this user. Defaults
@@ -396 +394 @@
         $avatar = get_avatar( $user_object->ID, 32 );
 
-        $r = "<tr id='user-$user_object->ID'$style>";
+        $r = "<tr id='user-$user_object->ID'>";
 
         list( $columns, $hidden ) = $this->get_column_info();