WordPress.org

Make WordPress Core


Ignore:
Timestamp:
01/16/2015 01:05:52 AM (5 years ago)
Author:
wonderboymusic
Message:

In PHP 5.0.0, is_a() became deprecated in favour of the instanceof operator. Calling is_a() would result in an E_STRICT warning.

In PHP 5.3.0, is_a() is no longer deprecated, and will therefore no longer throw E_STRICT warnings.

To avoid warnings in PHP < 5.3.0, convert all is_a() calls to $var instanceof WP_Class calls.

instanceof does not throw any error if the variable being tested is not an object, it simply returns false.

Props markoheijnen, wonderboymusic.
Fixes #25672.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/class-wp-error.php

    r31138 r31188  
    215215 * @return bool True, if WP_Error. False, if not WP_Error.
    216216 */
    217 function is_wp_error($thing) {
    218     if ( is_object($thing) && is_a($thing, 'WP_Error') )
    219         return true;
    220     return false;
     217function is_wp_error( $thing ) {
     218    return ( $thing instanceof WP_Error );
    221219}
Note: See TracChangeset for help on using the changeset viewer.