Changeset 31190 for trunk/src/wp-includes/capabilities.php

Timestamp:

01/16/2015 01:48:36 AM (10 years ago)

Author:

wonderboymusic

Message:

In WP_User, ->get_role_caps() and ->update_user_level_from_caps() must be called inside ->add_cap() and ->remove_cap() after updating user meta. ->has_cap() checks are currently failing directly after calling ->add_cap().

Adds unit test.

Props rachelbaker.
Fixes #28374.

File:

• trunk/src/wp-includes/capabilities.php (modified) (2 diffs)

trunk/src/wp-includes/capabilities.php

@@ -935 +935 @@
         $this->caps[$cap] = $grant;
         update_user_meta( $this->ID, $this->cap_key, $this->caps );
+        $this->get_role_caps();
+        $this->update_user_level_from_caps();
     }
 
@@ -946 +948 @@
      */
     public function remove_cap( $cap ) {
-        if ( ! isset( $this->caps[$cap] ) )
+        if ( ! isset( $this->caps[ $cap ] ) ) {
             return;
-        unset( $this->caps[$cap] );
+        }
+        unset( $this->caps[ $cap ] );
         update_user_meta( $this->ID, $this->cap_key, $this->caps );
+        $this->get_role_caps();
+        $this->update_user_level_from_caps();
     }