Changeset 31206 for trunk/src/wp-includes/taxonomy.php

Timestamp:

01/16/2015 04:45:21 PM (10 years ago)

Author:

boonebgorges

Message:

Bail out of hierarchy loops in _pad_term_counts().

Taxonomy hierarchy loops should not occur naturally, but when they do, the
logic of _pad_term_counts() could result in infinite loops, leading to
timeouts. We avoid this by breaking when a loop is detected.

Fixes #20635.

File:

• trunk/src/wp-includes/taxonomy.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -3917 +3917 @@
 
     // Touch every ancestor's lookup row for each post in each term
+    $ancestors = array();
     foreach ( $term_ids as $term_id ) {
+        $ancestors[] = $term_id;
         $child = $term_id;
         while ( !empty( $terms_by_id[$child] ) && $parent = $terms_by_id[$child]->parent ) {
+            if ( in_array( $parent, $ancestors ) ) {
+                break;
+            }
+
             if ( !empty( $term_items[$term_id] ) )
                 foreach ( $term_items[$term_id] as $item_id => $touches ) {