Changeset 31207 for trunk/tests/phpunit/tests/term/getTerms.php

Timestamp:

01/16/2015 05:09:11 PM (11 years ago)

Author:

boonebgorges

Message:

Bail out of hierarchy loops in _get_term_children().

This prevents infinite loops that lead to PHP nesting limit fatal errors.

Props boonebgorges, sgrant.
Fixes #24461.

File:

• trunk/tests/phpunit/tests/term/getTerms.php (modified) (1 diff)

trunk/tests/phpunit/tests/term/getTerms.php

@@ -393 +393 @@
 
         add_filter( 'wp_update_term_parent', 'wp_check_term_hierarchy_for_loops', 10, 3 );
+    }
+
+    /**
+     * @covers ::_get_term_children
+     * @ticket 24461
+     */
+    public function test__get_term_children_handles_cycles() {
+        remove_filter( 'wp_update_term_parent', 'wp_check_term_hierarchy_for_loops', 10 );
+
+        $c1 = $this->factory->category->create();
+        $c2 = $this->factory->category->create( array( 'parent' => $c1 ) );
+        $c3 = $this->factory->category->create( array( 'parent' => $c2 ) );
+        wp_update_term( $c1, 'category', array( 'parent' => $c3 ) );
+
+        add_filter( 'wp_update_term_parent', 'wp_check_term_hierarchy_for_loops', 10, 3 );
+
+        $result = _get_term_children( $c1, array( $c1, $c2, $c3 ), 'category' );
+
+        $this->assertEqualSets( array( $c2, $c3 ), $result );
+    }
+
+    /**
+     * @covers ::_get_term_children
+     * @ticket 24461
+     */
+    public function test__get_term_children_handles_cycles_when_terms_argument_contains_objects() {
+        remove_filter( 'wp_update_term_parent', 'wp_check_term_hierarchy_for_loops', 10 );
+
+        $c1 = $this->factory->category->create_and_get();
+        $c2 = $this->factory->category->create_and_get( array( 'parent' => $c1->term_id ) );
+        $c3 = $this->factory->category->create_and_get( array( 'parent' => $c2->term_id ) );
+        wp_update_term( $c1->term_id, 'category', array( 'parent' => $c3->term_id ) );
+
+        add_filter( 'wp_update_term_parent', 'wp_check_term_hierarchy_for_loops', 10, 3 );
+
+        $result = _get_term_children( $c1->term_id, array( $c1, $c2, $c3 ), 'category' );
+
+        $this->assertEqualSets( array( $c2, $c3 ), $result );
     }