Changeset 31218

Timestamp:

01/16/2015 09:36:12 PM (10 years ago)

Author:

boonebgorges

Message:

In get_edit_term_link(), default to a valid $object_type.

The $object_type param is used to set the 'post_type' query var, which
determines the post type menu that will be expanded when clicking through to
the term edit page. Not all taxonomies are associated with Posts, so it makes
sense to default to a post_type that the taxonomy is actually associated with.

Props DzeryCZ, juliobox.
Fixes #29251.

File:

• trunk/src/wp-includes/link-template.php (modified) (2 diffs)

trunk/src/wp-includes/link-template.php

@@ -889 +889 @@
  * @since 3.1.0
  *
- * @param int $term_id Term ID
- * @param string $taxonomy Taxonomy
- * @param string $object_type The object type
+ * @param int    $term_id     Term ID.
+ * @param string $taxonomy    Taxonomy.
+ * @param string $object_type The object type. Used to highlight the proper post type menu on the linked page.
+ *                            Defaults to the first object_type associated with the taxonomy.
  * @return string The edit term link URL for the given term.
  */
@@ -907 +908 @@
     );
 
-    if ( $object_type )
+    if ( $object_type ) {
         $args['post_type'] = $object_type;
+    } else if ( ! empty( $tax->object_type ) ) {
+        $args['post_type'] = reset( $tax->object_type );
+    }
 
     $location = add_query_arg( $args, admin_url( 'edit-tags.php' ) );