Changeset 31220 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

01/16/2015 10:50:20 PM (10 years ago)

Author:

wonderboymusic

Message:

Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions:

• In WP_Importer->is_user_over_quota(), the default value for the first argument for upload_is_user_over_quota() is true. Don't bother passing 1.
• When calling submit_button() with no $name, pass empty string instead of false.
• The default value for the 2nd argument to get_edit_post_link() is 'display'. Because PHP is PHP, passing true is the same as passing 'display' or nothing. Don't bother passing true.
• In WP_User_Meta_Session_Tokens::drop_sessions(), pass 0 instead of false to delete_metadata() as the value for $object_id, which expects an int.

See #30799.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -338 +338 @@
     <label class="screen-reader-text" for="<?php echo $input_id ?>"><?php echo $text; ?>:</label>
     <input type="search" id="<?php echo $input_id ?>" name="s" value="<?php _admin_search_query(); ?>" />
-    <?php submit_button( $text, 'button', false, false, array('id' => 'search-submit') ); ?>
+    <?php submit_button( $text, 'button', '', false, array('id' => 'search-submit') ); ?>
 </p>
 <?php
@@ -446 +446 @@
         echo "</select>\n";
 
-        submit_button( __( 'Apply' ), 'action', false, false, array( 'id' => "doaction$two" ) );
+        submit_button( __( 'Apply' ), 'action', '', false, array( 'id' => "doaction$two" ) );
         echo "\n";
     }