WordPress.org

Make WordPress Core


Ignore:
Timestamp:
01/16/2015 10:50:20 PM (7 years ago)
Author:
wonderboymusic
Message:

Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions:

  • In WP_Importer->is_user_over_quota(), the default value for the first argument for upload_is_user_over_quota() is true. Don't bother passing 1.
  • When calling submit_button() with no $name, pass empty string instead of false.
  • The default value for the 2nd argument to get_edit_post_link() is 'display'. Because PHP is PHP, passing true is the same as passing 'display' or nothing. Don't bother passing true.
  • In WP_User_Meta_Session_Tokens::drop_sessions(), pass 0 instead of false to delete_metadata() as the value for $object_id, which expects an int.

See #30799.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-list-table.php

    r31211 r31220  
    338338    <label class="screen-reader-text" for="<?php echo $input_id ?>"><?php echo $text; ?>:</label>
    339339    <input type="search" id="<?php echo $input_id ?>" name="s" value="<?php _admin_search_query(); ?>" />
    340     <?php submit_button( $text, 'button', false, false, array('id' => 'search-submit') ); ?>
     340    <?php submit_button( $text, 'button', '', false, array('id' => 'search-submit') ); ?>
    341341</p>
    342342<?php
     
    446446        echo "</select>\n";
    447447
    448         submit_button( __( 'Apply' ), 'action', false, false, array( 'id' => "doaction$two" ) );
     448        submit_button( __( 'Apply' ), 'action', '', false, array( 'id' => "doaction$two" ) );
    449449        echo "\n";
    450450    }
Note: See TracChangeset for help on using the changeset viewer.