Changeset 31220 for trunk/src/wp-admin/includes/class-wp-media-list-table.php

Timestamp:

01/16/2015 10:50:20 PM (10 years ago)

Author:

wonderboymusic

Message:

Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions:

• In WP_Importer->is_user_over_quota(), the default value for the first argument for upload_is_user_over_quota() is true. Don't bother passing 1.
• When calling submit_button() with no $name, pass empty string instead of false.
• The default value for the 2nd argument to get_edit_post_link() is 'display'. Because PHP is PHP, passing true is the same as passing 'display' or nothing. Don't bother passing true.
• In WP_User_Meta_Session_Tokens::drop_sessions(), pass 0 instead of false to delete_metadata() as the value for $object_id, which expects an int.

See #30799.

File:

• trunk/src/wp-admin/includes/class-wp-media-list-table.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -316 +316 @@
                 } else {
 ?>
-                <a href="<?php echo get_edit_post_link( $post->ID, true ); ?>" title="<?php echo esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $att_title ) ); ?>">
+                <a href="<?php echo get_edit_post_link( $post->ID ); ?>" title="<?php echo esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $att_title ) ); ?>">
                     <?php echo $thumb; ?>
                 </a>
@@ -333 +333 @@
                 echo $att_title;
             } else { ?>
-            <a href="<?php echo get_edit_post_link( $post->ID, true ); ?>"
+            <a href="<?php echo get_edit_post_link( $post->ID ); ?>"
                 title="<?php echo esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $att_title ) ); ?>">
                 <?php echo $att_title; ?></a>
@@ -502 +502 @@
         if ( $this->detached ) {
             if ( current_user_can( 'edit_post', $post->ID ) )
-                $actions['edit'] = '<a href="' . get_edit_post_link( $post->ID, true ) . '">' . __( 'Edit' ) . '</a>';
+                $actions['edit'] = '<a href="' . get_edit_post_link( $post->ID ) . '">' . __( 'Edit' ) . '</a>';
             if ( current_user_can( 'delete_post', $post->ID ) )
                 if ( EMPTY_TRASH_DAYS && MEDIA_TRASH ) {
@@ -516 +516 @@
         else {
             if ( current_user_can( 'edit_post', $post->ID ) && !$this->is_trash )
-                $actions['edit'] = '<a href="' . get_edit_post_link( $post->ID, true ) . '">' . __( 'Edit' ) . '</a>';
+                $actions['edit'] = '<a href="' . get_edit_post_link( $post->ID ) . '">' . __( 'Edit' ) . '</a>';
             if ( current_user_can( 'delete_post', $post->ID ) ) {
                 if ( $this->is_trash )