Changeset 31261

Timestamp:

01/21/2015 08:59:15 PM (10 years ago)

Author:

lancewillett

Message:

Twenty Twelve: fix escaping and minor code style issues. See #29127.

Location:

trunk/src/wp-content/themes/twentytwelve

Files:

• author.php (modified) (1 diff)
• functions.php (modified) (1 diff)
• image.php (modified) (1 diff)

trunk/src/wp-content/themes/twentytwelve/author.php

@@ -30 +30 @@
 
             <header class="archive-header">
-                <h1 class="archive-title"><?php printf( __( 'Author Archives: %s', 'twentytwelve' ), '<span class="vcard"><a class="url fn n" href="' . esc_url( get_author_posts_url( get_the_author_meta( "ID" ) ) ) . '" title="' . esc_attr( get_the_author() ) . '" rel="me">' . get_the_author() . '</a></span>' ); ?></h1>
+                <h1 class="archive-title"><?php printf( __( 'Author Archives: %s', 'twentytwelve' ), '<span class="vcard"><a class="url fn n" href="' . esc_url( get_author_posts_url( get_the_author_meta( 'ID' ) ) ) . '" title="' . esc_attr( get_the_author() ) . '" rel="me">' . get_the_author() . '</a></span>' ); ?></h1>
             </header><!-- .archive-header -->
 

trunk/src/wp-content/themes/twentytwelve/functions.php

@@ -280 +280 @@
     global $wp_query;
 
-    $html_id = esc_attr( $html_id );
-
     if ( $wp_query->max_num_pages > 1 ) : ?>
-        <nav id="<?php echo $html_id; ?>" class="navigation" role="navigation">
+        <nav id="<?php echo esc_attr( $html_id ); ?>" class="navigation" role="navigation">
             <h3 class="assistive-text"><?php _e( 'Post navigation', 'twentytwelve' ); ?></h3>
             <div class="nav-previous"><?php next_posts_link( __( '<span class="meta-nav">&larr;</span> Older posts', 'twentytwelve' ) ); ?></div>
             <div class="nav-next"><?php previous_posts_link( __( 'Newer posts <span class="meta-nav">&rarr;</span>', 'twentytwelve' ) ); ?></div>
-        </nav><!-- #<?php echo $html_id; ?> .navigation -->
+        </nav><!-- .navigation -->
     <?php endif;
 }

trunk/src/wp-content/themes/twentytwelve/image.php

@@ -67 +67 @@
     else :
         // or get the URL of the first image attachment
-        $next_attachment_url = get_attachment_link( $attachments[ 0 ]->ID );
+        $next_attachment_url = get_attachment_link( $attachments[0]->ID );
     endif;
 else :