Changeset 31265 for trunk/src/wp-content/themes/twentyeleven/functions.php

Timestamp:

01/22/2015 12:41:36 AM (10 years ago)

Author:

lancewillett

Message:

Twenty Eleven: fix escaping and minor code style issues. See #29127.

File:

• trunk/src/wp-content/themes/twentyeleven/functions.php (modified) (8 diffs)

trunk/src/wp-content/themes/twentyeleven/functions.php

@@ -331 +331 @@
     <div id="headimg">
         <?php
-        $color = get_header_textcolor();
-        $image = get_header_image();
-        if ( $color && $color != 'blank' )
-            $style = ' style="color:#' . $color . '"';
-        else
-            $style = ' style="display:none"';
-        ?>
-        <h1 class="displaying-header-text"><a id="name"<?php echo $style; ?> onclick="return false;" href="<?php echo esc_url( home_url( '/' ) ); ?>" tabindex="-1"><?php bloginfo( 'name' ); ?></a></h1>
-        <div id="desc" class="displaying-header-text"<?php echo $style; ?>><?php bloginfo( 'description' ); ?></div>
-        <?php if ( $image ) : ?>
+        $color = get_header_textcolor();
+        $image = get_header_image();
+        $style = 'display: none;';
+        if ( $color && $color != 'blank' ) {
+            $style = 'color: #' . $color . ';';
+        }
+        ?>
+        <h1 class="displaying-header-text"><a id="name" style="<?php echo esc_attr( $style ); ?>" onclick="return false;" href="<?php echo esc_url( home_url( '/' ) ); ?>" tabindex="-1"><?php bloginfo( 'name' ); ?></a></h1>
+        <div id="desc" class="displaying-header-text" style="<?php echo esc_attr( $style ); ?>"><?php bloginfo( 'description' ); ?></div>
+        <?php if ( $image ) : ?>
             <img src="<?php echo esc_url( $image ); ?>" alt="" />
         <?php endif; ?>
@@ -447 +447 @@
         'id' => 'sidebar-1',
         'before_widget' => '<aside id="%1$s" class="widget %2$s">',
-        'after_widget' => "</aside>",
+        'after_widget' => '</aside>',
         'before_title' => '<h3 class="widget-title">',
         'after_title' => '</h3>',
@@ -457 +457 @@
         'description' => __( 'The sidebar for the optional Showcase Template', 'twentyeleven' ),
         'before_widget' => '<aside id="%1$s" class="widget %2$s">',
-        'after_widget' => "</aside>",
+        'after_widget' => '</aside>',
         'before_title' => '<h3 class="widget-title">',
         'after_title' => '</h3>',
@@ -467 +467 @@
         'description' => __( 'An optional widget area for your site footer', 'twentyeleven' ),
         'before_widget' => '<aside id="%1$s" class="widget %2$s">',
-        'after_widget' => "</aside>",
+        'after_widget' => '</aside>',
         'before_title' => '<h3 class="widget-title">',
         'after_title' => '</h3>',
@@ -477 +477 @@
         'description' => __( 'An optional widget area for your site footer', 'twentyeleven' ),
         'before_widget' => '<aside id="%1$s" class="widget %2$s">',
-        'after_widget' => "</aside>",
+        'after_widget' => '</aside>',
         'before_title' => '<h3 class="widget-title">',
         'after_title' => '</h3>',
@@ -487 +487 @@
         'description' => __( 'An optional widget area for your site footer', 'twentyeleven' ),
         'before_widget' => '<aside id="%1$s" class="widget %2$s">',
-        'after_widget' => "</aside>",
+        'after_widget' => '</aside>',
         'before_title' => '<h3 class="widget-title">',
         'after_title' => '</h3>',
@@ -582 +582 @@
 
     if ( $class )
-        echo 'class="' . $class . '"';
+        echo 'class="' . esc_attr( $class ) . '"';
 }
 
@@ -718 +718 @@
         $galleries = get_post_galleries( get_the_ID(), false );
         if ( isset( $galleries[0]['ids'] ) )
-            $images = explode( ',', $galleries[0]['ids'] );
+            $images = explode( ',', $galleries[0]['ids'] );
     } else {
         $pattern = get_shortcode_regex();