Make WordPress Core


Ignore:
Timestamp:
01/22/2015 12:41:36 AM (10 years ago)
Author:
lancewillett
Message:

Twenty Eleven: fix escaping and minor code style issues. See #29127.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-content/themes/twentyeleven/inc/widgets.php

    r27597 r31265  
    2323        $this->alt_option_name = 'widget_twentyeleven_ephemera';
    2424
    25         add_action( 'save_post', array(&$this, 'flush_widget_cache' ) );
    26         add_action( 'deleted_post', array(&$this, 'flush_widget_cache' ) );
    27         add_action( 'switch_theme', array(&$this, 'flush_widget_cache' ) );
     25        add_action( 'save_post', array( &$this, 'flush_widget_cache' ) );
     26        add_action( 'deleted_post', array( &$this, 'flush_widget_cache' ) );
     27        add_action( 'switch_theme', array( &$this, 'flush_widget_cache' ) );
    2828    }
    2929
     
    3939        $cache = wp_cache_get( 'widget_twentyeleven_ephemera', 'widget' );
    4040
    41         if ( !is_array( $cache ) )
     41        if ( ! is_array( $cache ) )
    4242            $cache = array();
    4343
     
    4545            $args['widget_id'] = null;
    4646
    47         if ( isset( $cache[$args['widget_id']] ) ) {
    48             echo $cache[$args['widget_id']];
     47        if ( isset( $cache[ $args['widget_id'] ] ) ) {
     48            echo $cache[ $args['widget_id'] ];
    4949            return;
    5050        }
     
    5454
    5555        /** This filter is documented in wp-includes/default-widgets.php */
    56         $title = apply_filters( 'widget_title', empty( $instance['title'] ) ? __( 'Ephemera', 'twentyeleven' ) : $instance['title'], $instance, $this->id_base);
     56        $args['title'] = apply_filters( 'widget_title', empty( $instance['title'] ) ? __( 'Ephemera', 'twentyeleven' ) : $instance['title'], $instance, $this->id_base );
    5757
    5858        if ( ! isset( $instance['number'] ) )
    5959            $instance['number'] = '10';
    6060
    61         if ( ! $number = absint( $instance['number'] ) )
    62             $number = 10;
     61        if ( ! $args['number'] = absint( $instance['number'] ) )
     62            $args['number'] = 10;
    6363
    6464        $ephemera_args = array(
    65             'order' => 'DESC',
    66             'posts_per_page' => $number,
    67             'no_found_rows' => true,
    68             'post_status' => 'publish',
    69             'post__not_in' => get_option( 'sticky_posts' ),
    70             'tax_query' => array(
     65            'order'          => 'DESC',
     66            'posts_per_page' => $args['number'],
     67            'no_found_rows'  => true,
     68            'post_status'    => 'publish',
     69            'post__not_in'   => get_option( 'sticky_posts' ),
     70            'tax_query'      => array(
    7171                array(
    7272                    'taxonomy' => 'post_format',
    73                     'terms' => array( 'post-format-aside', 'post-format-link', 'post-format-status', 'post-format-quote' ),
    74                     'field' => 'slug',
     73                    'terms'    => array( 'post-format-aside', 'post-format-link', 'post-format-status', 'post-format-quote' ),
     74                    'field'    => 'slug',
    7575                    'operator' => 'IN',
    7676                ),
     
    8080
    8181        if ( $ephemera->have_posts() ) :
    82             echo $before_widget;
    83             echo $before_title;
    84             echo $title; // Can set this with a widget option, or omit altogether
    85             echo $after_title;
     82            echo $args['before_widget'];
     83            echo $args['before_title'];
     84            echo $args['title'];
     85            echo $args['after_title'];
    8686            ?>
    8787            <ol>
     
    112112            <?php
    113113
    114             echo $after_widget;
     114            echo $args['after_widget'];
    115115
    116116            // Reset the post globals as this query will have stomped on it
     
    120120        endif;
    121121
    122         $cache[$args['widget_id']] = ob_get_flush();
     122        $cache[ $args['widget_id'] ] = ob_get_flush();
    123123        wp_cache_set( 'widget_twentyeleven_ephemera', $cache, 'widget' );
    124124    }
Note: See TracChangeset for help on using the changeset viewer.