Changeset 31272

Timestamp:

01/23/2015 06:17:25 PM (10 years ago)

Author:

jorbin

Message:

Improve accessibility of nav menu locations form.

A couple of small tweaks to the nav menu locations form that make it friendlier to assistive technology. These include:

• labels for selects
• better context for the "Edit" link. We hide "edit" from screen readers and instead give them a phrase with context since they may not be able to take advantage of the visual context

Additionally, there are some minor css tweaks to improve the visual alignment of the rows.
We also remove duplicate IDs and use classes instead.

Props afercia.
fixes #31090.

Location:

trunk/src/wp-admin

Files:

• css/nav-menus.css (modified) (2 diffs)
• nav-menus.php (modified) (3 diffs)

trunk/src/wp-admin/css/nav-menus.css

@@ -100 +100 @@
     float: left;
     margin-top: 1px;
-}
-
-.menu-edit p {
-    margin: .3em 0 .6em;
 }
 
@@ -217 +213 @@
 }
 
-.widefat td.menu-location-menus {
-    padding-bottom: 5px;
+.widefat .menu-locations tr + tr td {
+    padding-top: 0;
+}
+
+.widefat .menu-locations td {
+    vertical-align: middle;
+}
+
+.menu-location-title label {
+    font-weight: bold;
 }
 

trunk/src/wp-admin/nav-menus.php

@@ -582 +582 @@
                 <tbody class="menu-locations">
                 <?php foreach ( $locations as $_location => $_name ) { ?>
-                    <tr id="menu-locations-row">
-                        <td class="menu-location-title"><strong><?php echo $_name; ?></strong></td>
+                    <tr class="menu-locations-row">
+                        <td class="menu-location-title"><label for="locations-<?php echo $_location; ?>"><?php echo $_name; ?></label></td>
                         <td class="menu-location-menus">
                             <select name="menu-locations[<?php echo $_location; ?>]" id="locations-<?php echo $_location; ?>">
@@ -598 +598 @@
                                 <span class="locations-edit-menu-link">
                                     <a href="<?php echo esc_url( add_query_arg( array( 'action' => 'edit', 'menu' => $menu_locations[$_location] ), admin_url( 'nav-menus.php' ) ) ); ?>">
-                                        <?php _ex( 'Edit', 'menu' ); ?>
+                                        <span aria-hidden="true"><?php _ex( 'Edit', 'menu' ); ?></span><span class="screen-reader-text"><?php _e( 'Edit selected menu' ); ?></span>
                                     </a>
                                 </span>
@@ -607 +607 @@
                                     </a>
                                 </span>
-                            </div><!-- #locations-row-links -->
+                            </div><!-- .locations-row-links -->
                         </td><!-- .menu-location-menus -->
-                    </tr><!-- #menu-locations-row -->
+                    </tr><!-- .menu-locations-row -->
                 <?php } // foreach ?>
                 </tbody>