Changeset 31281

Timestamp:

01/25/2015 06:32:56 PM (10 years ago)

Author:

SergeyBiryukov

Message:

Revert [30027]. These fields are already sufficiently labeled; duplicate labels can lead to confused behavior for screen readers.

see #31117, #30101.

File:

• trunk/src/wp-admin/user-edit.php (modified) (2 diffs)

trunk/src/wp-admin/user-edit.php

@@ -247 +247 @@
 <?php if ( ! ( IS_PROFILE_PAGE && ! $user_can_edit ) ) : ?>
     <tr class="user-rich-editing-wrap">
-        <th scope="row"><label for="rich_editing"><?php _e( 'Visual Editor' )?></label></th>
+        <th scope="row"><?php _e( 'Visual Editor' ); ?></th>
         <td><label for="rich_editing"><input name="rich_editing" type="checkbox" id="rich_editing" value="false" <?php if ( ! empty( $profileuser->rich_editing ) ) checked( 'false', $profileuser->rich_editing ); ?> /> <?php _e( 'Disable the visual editor when writing' ); ?></label></td>
     </tr>
@@ -273 +273 @@
 if ( !( IS_PROFILE_PAGE && !$user_can_edit ) ) : ?>
 <tr class="user-comment-shortcuts-wrap">
-<th scope="row"><label for="comment_shortcuts"><?php _e( 'Keyboard Shortcuts' ); ?></label></th>
+<th scope="row"><?php _e( 'Keyboard Shortcuts' ); ?></th>
 <td><label for="comment_shortcuts"><input type="checkbox" name="comment_shortcuts" id="comment_shortcuts" value="true" <?php if ( ! empty( $profileuser->comment_shortcuts ) ) checked( 'true', $profileuser->comment_shortcuts ); ?> /> <?php _e('Enable keyboard shortcuts for comment moderation.'); ?></label> <?php _e('<a href="http://codex.wordpress.org/Keyboard_Shortcuts" target="_blank">More information</a>'); ?></td>
 </tr>
 <?php endif; ?>
 <tr class="show-admin-bar user-admin-bar-front-wrap">
-<th scope="row"><label for="admin_bar_front"><?php _e( 'Toolbar' )?></label></th>
+<th scope="row"><?php _e( 'Toolbar' ); ?></th>
 <td><fieldset><legend class="screen-reader-text"><span><?php _e('Toolbar') ?></span></legend>
 <label for="admin_bar_front">