Changeset 31300

Timestamp:

01/29/2015 09:14:54 PM (10 years ago)

Author:

SergeyBiryukov

Message:

Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.

props tomdxw.
fixes #30927.

Location:

trunk/src/wp-admin/includes

Files:

• menu.php (modified) (1 diff)
• ms.php (modified) (2 diffs)

trunk/src/wp-admin/includes/menu.php

@@ -317 +317 @@
     do_action( 'admin_page_access_denied' );
 
-    wp_die( __('You do not have sufficient permissions to access this page.') );
+    wp_die( __( 'You do not have sufficient permissions to access this page.' ), 403 );
 }
 

trunk/src/wp-admin/includes/ms.php

@@ -626 +626 @@
 
     if ( empty( $blogs ) )
-        wp_die( sprintf( __( 'You attempted to access the "%1$s" dashboard, but you do not currently have privileges on this site. If you believe you should be able to access the "%1$s" dashboard, please contact your network administrator.' ), $blog_name ) );
+        wp_die( sprintf( __( 'You attempted to access the "%1$s" dashboard, but you do not currently have privileges on this site. If you believe you should be able to access the "%1$s" dashboard, please contact your network administrator.' ), $blog_name ), 403 );
 
     $output = '<p>' . sprintf( __( 'You attempted to access the "%1$s" dashboard, but you do not currently have privileges on this site. If you believe you should be able to access the "%1$s" dashboard, please contact your network administrator.' ), $blog_name ) . '</p>';
@@ -644 +644 @@
     $output .= '</table>';
 
-    wp_die( $output );
+    wp_die( $output, 403 );
 }
 add_action( 'admin_page_access_denied', '_access_denied_splash', 99 );